maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/castore): B3Digest::{to_vec -> as_slice}

Browse source 
Not a single call site actually makes use of the Vec.

Change-Id: I6cf31073c9f443d1702a21937a0c3938c2c643b8
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9988
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
This commit is contained in:
edef 2023-11-07 12:09:37 +00:00
parent 9f5b1213f9
commit a8e7f4eadb
7 changed files with 17 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tvix/castore/src/proto/grpc_blobservice_wrapper.rs
View file

@ -167,8 +167,7 @@ impl super::blob_service_server::BlobService for GRPCBlobServiceWrapper {
warn!("error closing stream: {}", e);
Status::internal("error closing stream")
})
.await?
.to_vec();
.await?;
Ok(Response::new(super::PutBlobResponse {
digest: digest.into(),

2
tvix/castore/src/proto/tests/grpc_blobservice.rs
View file

@ -54,7 +54,7 @@ async fn put_read_stat() {
.expect("must succeed")
.into_inner();
assert_eq!(BLOB_A_DIGEST.to_vec(), put_resp.digest);
assert_eq!(BLOB_A_DIGEST.as_slice(), put_resp.digest);
// Stat for the digest of A.
// We currently don't ask for more granular chunking data, as we don't

6
tvix/castore/src/proto/tests/grpc_directoryservice.rs
View file

@ -74,7 +74,7 @@ async fn put_get() {
};
// the sent root_digest should match the calculated digest
assert_eq!(put_resp.root_digest, DIRECTORY_A.digest().to_vec());
assert_eq!(put_resp.root_digest, DIRECTORY_A.digest().as_slice());
// get it back
let items = get_directories(
@ -117,7 +117,7 @@ async fn put_get_multiple() {
.into_inner()
};
assert_eq!(DIRECTORY_B.digest().to_vec(), put_resp.root_digest);
assert_eq!(DIRECTORY_B.digest().as_slice(), put_resp.root_digest);
// now, request b, first in non-recursive mode.
let items = get_directories(
@ -167,7 +167,7 @@ async fn put_get_dedup() {
};
assert_eq!(
DIRECTORY_C.digest().to_vec(),
DIRECTORY_C.digest().as_slice(),
put_resp.into_inner().root_digest
);