maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): parseDrvName should not coerce, and xfail test

Browse source 
builtins.parseDrvName should not coerce its argument to a string.
This commit fixes that oversight in my previous commit, and adds an
xfail test to cover this condition.

Thanks to @sterni for noticing this.

Signed-off-by: Adam Joseph <adam@westernsemico.com>
Change-Id: I76bc78f1a82e1e08fe5c787c563a221d55de2639
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6991
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Adam Joseph 2022-10-12 20:11:48 -07:00
parent 01bc04b1d2
commit a98cb9d56f
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-fail-parsedrvname-coerce.nix Normal file
View file

@ -0,0 +1 @@
builtins.parseDrvName { outPath = "lol"; }