maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): address various clippy lints

Browse source 
Change-Id: I3ea0f51475e80948adfeb5d1620c1f2665cc39bc
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6201
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Vincent Ambo 2022-08-14 02:51:09 +03:00 • committed by tazjin
parent c4f73eecdc
commit ab9407bded
6 changed files with 30 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tvix/eval/src/value/mod.rs
View file

@ -33,11 +33,7 @@ pub enum Value {
impl Value {
pub fn is_number(&self) -> bool {
match self {
Value::Integer(_) => true,
Value::Float(_) => true,
_ => false,
}
matches!(self, Value::Integer(_) | Value::Float(_))
}
pub fn type_of(&self) -> &'static str {
@ -66,7 +62,7 @@ impl Value {
}
}
pub fn as_string(self) -> EvalResult<NixString> {
pub fn to_string(self) -> EvalResult<NixString> {
match self {
Value::String(s) => Ok(s),
other => Err(Error::TypeError {
@ -76,7 +72,7 @@ impl Value {
}
}
pub fn as_attrs(self) -> EvalResult<Rc<NixAttrs>> {
pub fn to_attrs(self) -> EvalResult<Rc<NixAttrs>> {
match self {
Value::Attrs(s) => Ok(s),
other => Err(Error::TypeError {
@ -86,7 +82,7 @@ impl Value {
}
}
pub fn as_list(self) -> EvalResult<NixList> {
pub fn to_list(self) -> EvalResult<NixList> {
match self {
Value::List(l) => Ok(l),
other => Err(Error::TypeError {