refactor(tvix/cli/args): remove log-level argument

RUST_LOG allows for a more granular tracing configuration

Change-Id: Iea29fc2b154345eb7479dfd8bbea6abfd4716341
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12585
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>

tvix/cli/src/args.rs

@@ -1,7 +1,6 @@
 use std::path::PathBuf;
 
 use clap::Parser;
-use tracing::Level;
 use tvix_store::utils::ServiceUrlsMemory;
 
 /// Provides a CLI interface to trigger evaluation using tvix-eval.
@@ -14,13 +13,6 @@ use tvix_store::utils::ServiceUrlsMemory;
 /// The CLI interface is not stable and subject to change.
 #[derive(Parser, Clone)]
 pub struct Args {
-    /// A global log level to use when printing logs.
-    /// It's also possible to set `RUST_LOG` according to
-    /// `tracing_subscriber::filter::EnvFilter`, which will always have
-    /// priority.
-    #[arg(long, default_value_t=Level::INFO)]
-    pub log_level: Level,
-
     /// Path to a script to evaluate
     pub script: Option<PathBuf>,
 

tvix/cli/src/main.rs

@@ -53,7 +53,6 @@ fn main() {
     let args = Args::parse();
 
     let _ = tvix_tracing::TracingBuilder::default()
-        .level(args.log_level)
         .enable_progressbar()
         .build()
         .expect("unable to set up tracing subscriber");

tvix/docs/src/TODO.md

@@ -262,9 +262,6 @@ This requires some more designing. Some goals:
 - Some work ongoing on the worker operation parsing (griff, picnoir)
 
 ### O11Y
- - Maybe drop `--log-level` entirely, and only use `RUST_LOG` env exclusively?
-   `debug`,`trace` level across all crates is a bit useless, and `RUST_LOG` can
-   be much more granular…
  - Trace propagation for object_store once they support a way to register a
    middleware, so we can use that to register a tracing middleware.
    https://github.com/apache/arrow-rs/issues/5990