maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/eval): Forbid Hash{Map,Set}, use Fx instead

Browse source 
Per https://nnethercote.github.io/perf-book/hashing.html, we have
basically no reason to use the default hasher over a faster,
non-DoS-resistant hasher. This gives a nice perf boost basically for
free:

hello outpath           time:   [704.76 ms 714.91 ms 725.63 ms]
                        change: [-7.2391% -6.1018% -4.9189%] (p = 0.00 < 0.05)
                        Performance has improved.

Change-Id: If5587f444ed3af69f8af4eead6af3ea303b4ae68
Reviewed-on: https://cl.tvl.fyi/c/depot/+/12046
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Autosubmit: aspen <root@gws.fyi>
This commit is contained in:
Aspen Smith 2024-07-28 12:11:41 -04:00 • committed by clbot
parent 1d7ba89c19
commit b8f92a6d53
17 changed files with 116 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

9
web/tvixbolt/Cargo.lock generated
View file

@ -1223,7 +1223,7 @@ dependencies = [
"countme",
"hashbrown 0.14.5",
"memoffset",
"rustc-hash",
"rustc-hash 1.1.0",
"text-size",
]
@ -1239,6 +1239,12 @@ version = "1.1.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "08d43f7aa6b08d49f382cde6a7982047c3426db949b1424bc4b7ec9ae12c6ce2"
[[package]]
name = "rustc-hash"
version = "2.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "583034fd73374156e66797ed8e5b0d5690409c9226b22d87cb7f19821c05d152"
[[package]]
name = "rustversion"
version = "1.0.17"
@ -1561,6 +1567,7 @@ dependencies = [
"regex",
"rnix",
"rowan",
"rustc-hash 2.0.0",
"serde",
"serde_json",
"sha1",

22
web/tvixbolt/Cargo.nix
View file

@ -3668,7 +3668,7 @@ rec {
}
{
name = "rustc-hash";
packageId = "rustc-hash";
packageId = "rustc-hash 1.1.0";
}
{
name = "text-size";
@ -3695,7 +3695,7 @@ rec {
"rustc-dep-of-std" = [ "core" "compiler_builtins" ];
};
};
"rustc-hash" = rec {
"rustc-hash 1.1.0" = rec {
crateName = "rustc-hash";
version = "1.1.0";
edition = "2015";
@ -3708,6 +3708,20 @@ rec {
};
resolvedDefaultFeatures = [ "default" "std" ];
};
"rustc-hash 2.0.0" = rec {
crateName = "rustc-hash";
version = "2.0.0";
edition = "2021";
sha256 = "0lni0lf846bzrf3jvci6jaf4142n1mdqxvcpczk5ch9pfgyk8c2q";
authors = [
"The Rust Project Developers"
];
features = {
"default" = [ "std" ];
"rand" = [ "dep:rand" "std" ];
};
resolvedDefaultFeatures = [ "default" "std" ];
};
"rustversion" = rec {
crateName = "rustversion";
version = "1.0.17";
@ -4642,6 +4656,10 @@ rec {
name = "rowan";
packageId = "rowan";
}
{
name = "rustc-hash";
packageId = "rustc-hash 2.0.0";
}
{
name = "serde";
packageId = "serde";