maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(tvix/eval): add builtins to builtins

Browse source 
This is a somewhat terrifying hack that enables us to support
`builtins.builtins`, by running a "fake compilation" inside of a
suspended native thunk that can resolve the weak pointer to the
globals.

With this implementation, the thunk at `builtins.builtins` actually
resolves to the "real" `builtins` (verified with a new test).

This is kind of ugly, and it's something users shouldn't use, but
bubbling a warning out of this is difficult at the moment due to a
little bit of trickery with how the spans in suspended native thunks
work (they don't) (see b/237, b/238)

Change-Id: I67d0e93246dd5b279c960aeda00402031aa12af3
Reviewed-on: https://cl.tvl.fyi/c/depot/+/7748
Tested-by: BuildkiteCI
Reviewed-by: flokli <flokli@flokli.de>
This commit is contained in:
Vincent Ambo 2023-01-04 17:12:33 +03:00 • committed by tazjin
parent 79e54f46ce
commit b9646ab40c
3 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-builtins.exp Normal file
View file

@ -0,0 +1 @@
true

1
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-builtins.nix Normal file
View file

@ -0,0 +1 @@
[ builtins ] == [ builtins.builtins ]