From bbf1e3273751a294bdff7329fae022bce4963b66 Mon Sep 17 00:00:00 2001 From: sterni Date: Wed, 19 Oct 2022 19:19:03 +0200 Subject: [PATCH] fix(tvix/eval): restore .exp.xml files and skip in test suite Change-Id: Iebda5e0d99925a0a8c1d6ae1d7a35397d127bf31 Reviewed-on: https://cl.tvl.fyi/c/depot/+/7047 Autosubmit: sterni Reviewed-by: tazjin Tested-by: BuildkiteCI --- tvix/eval/src/tests/mod.rs | 7 +++++++ ...kay-functionargs.exp => eval-okay-functionargs.exp.xml} | 0 .../{eval-okay-xml.exp => eval-okay-xml.exp.xml} | 0 3 files changed, 7 insertions(+) rename tvix/eval/src/tests/nix_tests/notyetpassing/{eval-okay-functionargs.exp => eval-okay-functionargs.exp.xml} (100%) rename tvix/eval/src/tests/nix_tests/notyetpassing/{eval-okay-xml.exp => eval-okay-xml.exp.xml} (100%) diff --git a/tvix/eval/src/tests/mod.rs b/tvix/eval/src/tests/mod.rs index 8a58b3cc7..798cc7b87 100644 --- a/tvix/eval/src/tests/mod.rs +++ b/tvix/eval/src/tests/mod.rs @@ -9,9 +9,16 @@ fn eval_test(code_path: &str, expect_success: bool) { .strip_suffix("nix") .expect("test files always end in .nix"); let exp_path = format!("{}exp", base); + let exp_xml_path = std::path::PathBuf::from(format!("{}exp.xml", base)); let code = std::fs::read_to_string(code_path).expect("should be able to read test code"); + if exp_xml_path.exists() { + // We can't test them at the moment because we don't have XML output yet. + // Checking for success / failure only is a bit disingenious. + return; + } + match interpret(&code, Some(code_path.into()), Options::test_options()) { Ok(result) => { let result_str = format!("{}", result); diff --git a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-functionargs.exp b/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-functionargs.exp.xml similarity index 100% rename from tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-functionargs.exp rename to tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-functionargs.exp.xml diff --git a/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp b/tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp.xml similarity index 100% rename from tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp rename to tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp.xml