refactor(tvix/eval): add opcode::StackIdx type for less ambiguity

Change-Id: I9b9de1f681972c205d4d20bc5731d2ce79858edb
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6287
Tested-by: BuildkiteCI
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Vincent Ambo 2022-08-26 20:54:39 +03:00 committed by tazjin
parent 2cdc6192b4
commit c73e84d957
3 changed files with 14 additions and 9 deletions

View file

@ -11,6 +11,11 @@ pub struct ConstantIdx(pub usize);
#[derive(Clone, Copy, Debug)]
pub struct CodeIdx(pub usize);
/// Index of a value in the runtime stack.
#[repr(transparent)]
#[derive(Clone, Copy, Debug)]
pub struct StackIdx(pub usize);
/// Offset by which an instruction pointer should change in a jump.
#[repr(transparent)]
#[derive(Clone, Copy, Debug)]
@ -63,7 +68,7 @@ pub enum OpCode {
OpAttrsIsSet,
// `with`-handling
OpPushWith(usize),
OpPushWith(StackIdx),
OpPopWith,
OpResolveWith,
@ -78,7 +83,7 @@ pub enum OpCode {
OpAssertBool,
// Access local identifiers with statically known positions.
OpGetLocal(usize),
OpGetLocal(StackIdx),
// Close scopes while leaving their expression value around.
OpCloseScope(usize), // number of locals to pop