maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(tvix/eval): make sure to force before selecting in catAttrs

Browse source 
Previously, this would almost always crash because list items are
thunked more often nowadays and selecting from a thunk would fail. Also
we no longer pop from args, accessing it by index should avoid an
unnecessary clone here.

Change-Id: I4410c4c2e28cc255a2c7cf2a5322db3d2c556a0e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6693
Reviewed-by: grfn <grfn@gws.fyi>
Autosubmit: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
This commit is contained in:
sterni 2022-09-19 12:03:50 +02:00
parent 151f4437bc
commit cd280e0796
3 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-catAttrs.exp Normal file
View file

@ -0,0 +1 @@
[ 21 "+" 21 "=" 42 ]

10
tvix/eval/src/tests/tvix_tests/eval-okay-builtins-catAttrs.nix Normal file
View file

@ -0,0 +1,10 @@
builtins.catAttrs "foo" [
{ foo = 21; }
{ bar = 23; foo = "+"; }
{ }
{ bar = 12; }
{ foo = 21 + 0; }
{ foo = "="; }
({ bar = 13; } // { baz = 89; })
{ foo = 42; bar = 33; }
]