maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(snix/build): use try_into_name_and_node()

Browse source 
The BuildRequest trait currently still uses the proto Build struct
as a response type, and that one uses nodes with names, causing
.try_into_anonymous_node() to panic.

Use try_into_name_and_node(), and discard the name for now. We should
update the trait to use a stricter type for this.

Change-Id: Ib183a163e885443c58c42808e464d0611eaae324
Reviewed-on: https://cl.snix.dev/c/snix/+/30169
Reviewed-by: Vova Kryachko <v.kryachko@gmail.com>
Tested-by: besadii
Autosubmit: Florian Klink <flokli@flokli.de>
This commit is contained in:
Florian Klink 2025-03-20 12:14:44 +00:00 • committed by clbot
parent 37513fb3f2
commit d07107d688
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
snix/glue/src/snix_store_io.rs
View file

@ -291,9 +291,9 @@ impl SnixStoreIO {
.zip(build_result.outputs_needles.iter()) .zip(build_result.outputs_needles.iter())
.zip(drv.outputs.iter()) .zip(drv.outputs.iter())
{ {
let output_node = output let (_, output_node) = output
.clone() .clone()
.try_into_anonymous_node() .try_into_name_and_node()
.expect("invalid node"); .expect("invalid node");
let output_needles: Vec<_> = output_needles let output_needles: Vec<_> = output_needles