refactor(tvix): Make Store::buildPaths return a Status
Make Store::buildPaths return a Status with [[nodiscard]] rather than throwing exceptions to signal failure. This is the beginning of a long road to refactor the entire store API to be status/statusor based instead of using exceptions. Change-Id: I2e32371c95a25b87ad129987c217d49c6d6e0c85 Reviewed-on: https://cl.tvl.fyi/c/depot/+/1745 Tested-by: BuildkiteCI Reviewed-by: kanepyork <rikingcoding@gmail.com>
This commit is contained in:
		
							parent
							
								
									aef3607bd3
								
							
						
					
					
						commit
						d1c38d9597
					
				
					 18 changed files with 137 additions and 32 deletions
				
			
		
							
								
								
									
										3
									
								
								third_party/nix/src/libexpr/primops.cc
									
										
									
									
										vendored
									
									
								
							
							
						
						
									
										3
									
								
								third_party/nix/src/libexpr/primops.cc
									
										
									
									
										vendored
									
									
								
							|  | @ -22,6 +22,7 @@ | |||
| #include "libstore/store-api.hh" | ||||
| #include "libutil/archive.hh" | ||||
| #include "libutil/json.hh" | ||||
| #include "libutil/status.hh" | ||||
| #include "libutil/util.hh" | ||||
| 
 | ||||
| namespace nix { | ||||
|  | @ -90,7 +91,7 @@ void EvalState::realiseContext(const PathSet& context) { | |||
|   unsigned long long narSize; | ||||
|   store->queryMissing(drvs, willBuild, willSubstitute, unknown, downloadSize, | ||||
|                       narSize); | ||||
|   store->buildPaths(drvs); | ||||
|   nix::util::OkOrThrow(store->buildPaths(drvs)); | ||||
| } | ||||
| 
 | ||||
| /* Load and evaluate an expression from path specified by the
 | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue