maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(3p/nix): Apply clang-tidy's modernize-* fixes

Browse source 
This applies the modernization fixes listed here:

https://clang.llvm.org/extra/clang-tidy/checks/list.html

The 'modernize-use-trailing-return-type' fix was excluded due to my
personal preference (more specifically, I think the 'auto' keyword is
misleading in that position).
This commit is contained in:
Vincent Ambo 2020-05-20 04:33:07 +01:00
parent fed31b2c9b
commit d331d3a0b5
59 changed files with 349 additions and 321 deletions
Download patch file Download diff file Expand all files Collapse all files

7
third_party/nix/src/libstore/gc.cc vendored
View file

@ -1,11 +1,11 @@
#include <algorithm>
#include <cerrno>
#include <climits>
#include <functional>
#include <queue>
#include <random>
#include <regex>
#include <errno.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/statvfs.h>
@ -147,7 +147,7 @@ void LocalStore::addTempRoot(const Path& path) {
/* Create the temporary roots file for this process. */
if (!state->fdTempRoots) {
while (1) {
while (true) {
AutoCloseFD fdGCLock = openGCLock(ltRead);
if (pathExists(fnTempRoots)) {
@ -505,7 +505,8 @@ struct LocalStore::GCState {
unsigned long long bytesInvalidated;
bool moveToTrash = true;
bool shouldDelete;
explicit GCState(GCResults& results_) : results(results_), bytesInvalidated(0) {}
explicit GCState(GCResults& results_)
: results(results_), bytesInvalidated(0) {}
};
bool LocalStore::isActiveTempFile(const GCState& state, const Path& path,