maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* Wrap calls to registerSubstitute() in a single transaction to

Browse source 
improve throughput.
* Don't build the `substitute-rev' table for now, since it caused
  Theta(N^2) time and log file consumption when adding N substitutes.
  Maybe we can do without it.
This commit is contained in:
Eelco Dolstra 2004-06-21 07:38:17 +00:00
parent 15c60ca1b6
commit daf0a923c7
3 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/nix-store/main.cc
View file

@ -170,6 +170,9 @@ static void opSubstitute(Strings opFlags, Strings opArgs)
if (!opArgs.empty())
throw UsageError("no arguments expected");
Transaction txn;
createStoreTransaction(txn);
while (1) {
Path srcPath;
Substitute sub;
@ -188,8 +191,11 @@ static void opSubstitute(Strings opFlags, Strings opArgs)
sub.args.push_back(s);
}
if (!cin || cin.eof()) throw Error("missing input");
registerSubstitute(srcPath, sub);
cerr << ".";
registerSubstitute(txn, srcPath, sub);
}
txn.commit();
}