maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

revert(tvix/eval): Don't double-box Path values

Browse source 
This reverts commit d3d41552cf.

This was well-intentioned, but now the boxed Path values are actually
the *largest* Value enum variants, at 16 bytes (because they're
fat-pointers, with a len) instead of 8 bytes like all the other values.
Having the double reference is a reasonable price to pay (it seems; more
benchmarks may end up disagreeing) for a smaller Value repr.

Change-Id: I0d3e84f646c8f5ffd0b7259c4e456637eea360f7
Reviewed-on: https://cl.tvl.fyi/c/depot/+/10797
Tested-by: BuildkiteCI
Autosubmit: aspen <root@gws.fyi>
Reviewed-by: sterni <sternenseemann@systemli.org>
This commit is contained in:
Aspen Smith 2024-02-10 12:35:44 -05:00 • committed by clbot
parent e3c92ac3b4
commit dd26177319
6 changed files with 20 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tvix/eval/src/value/arbitrary.rs
View file

@ -2,7 +2,7 @@
use imbl::proptest::{ord_map, vector};
use proptest::{prelude::*, strategy::BoxedStrategy};
use std::{ffi::OsString, path::PathBuf};
use std::ffi::OsString;
use super::{attrs::AttrsRep, NixAttrs, NixList, NixString, Value};
@ -92,7 +92,7 @@ fn leaf_value() -> impl Strategy<Value = Value> {
any::<i64>().prop_map(Integer),
any::<f64>().prop_map(Float),
any::<Box<NixString>>().prop_map(String),
any::<OsString>().prop_map(|s| Path(PathBuf::from(s).into_boxed_path())),
any::<OsString>().prop_map(|s| Path(Box::new(s.into()))),
]
}