fix(3p/nix): apply all clang-tidy fixes

Change-Id: I265e763393422ee1881653527c91024458060825
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1432
Tested-by: BuildkiteCI
Reviewed-by: tazjin <mail@tazj.in>
This commit is contained in:
Kane York 2020-07-24 21:09:44 -07:00 committed by kanepyork
parent 69f402563a
commit ef54f5da9f
65 changed files with 580 additions and 497 deletions

View file

@ -37,8 +37,8 @@ void printGCWarning() {
}
void printMissing(const ref<Store>& store, const PathSet& paths) {
unsigned long long downloadSize;
unsigned long long narSize;
unsigned long long downloadSize = 0;
unsigned long long narSize = 0;
PathSet willBuild;
PathSet willSubstitute;
PathSet unknown;
@ -128,7 +128,7 @@ void initNix() {
startSignalHandlerThread();
/* Reset SIGCHLD to its default. */
struct sigaction act;
struct sigaction act {};
sigemptyset(&act.sa_mask);
act.sa_handler = SIG_DFL;
act.sa_flags = 0;
@ -151,7 +151,7 @@ void initNix() {
umask(0022);
/* Initialise the PRNG. */
struct timeval tv;
struct timeval tv {};
gettimeofday(&tv, nullptr);
srandom(tv.tv_usec);
}
@ -327,7 +327,7 @@ RunPager::RunPager() {
if (pager == nullptr) {
pager = getenv("PAGER");
}
if (pager && ((std::string)pager == "" || (std::string)pager == "cat")) {
if (pager && (std::string(pager) == "" || std::string(pager) == "cat")) {
return;
}