maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(tvix/eval): allow impure Value builtins

Browse source 
Allows impure builtins that have a different shape than a Rust
function pointer; specifically this is required for
builtins.currentTime which does not work in WASM.

Change-Id: I1362d8eeafe770ce4d1c5ebe4d119aeb0abb5c9b
Reviewed-on: https://cl.tvl.fyi/c/depot/+/6849
Reviewed-by: sterni <sternenseemann@systemli.org>
Tested-by: BuildkiteCI
Reviewed-by: grfn <grfn@gws.fyi>
Reviewed-by: wpcarro <wpcarro@gmail.com>
This commit is contained in:
Vincent Ambo 2022-10-03 11:26:32 +03:00 • committed by tazjin
parent b9bfcf2f33
commit f0179c92d3
2 changed files with 27 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tvix/eval/src/builtins/mod.rs
View file

@ -3,12 +3,10 @@
//! See //tvix/eval/docs/builtins.md for a some context on the
//! available builtins in Nix.
use std::{
cmp,
collections::{BTreeMap, HashMap},
path::PathBuf,
rc::Rc,
};
use std::cmp;
use std::collections::{BTreeMap, HashMap};
use std::path::PathBuf;
use std::rc::Rc;
use crate::{
errors::ErrorKind,
@ -385,7 +383,7 @@ fn builtins_set() -> NixAttrs {
add_builtins(pure_builtins());
#[cfg(feature = "impure")]
{
add_builtins(impure::builtins());
map.extend(impure::builtins());
}
NixAttrs::from_map(map)