maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(users/Profpatsch/read-http): actually parse ascii

Browse source 
There might be exploits since we parsed the headers as utf8 even
though we actually want to interpret them as ASCII.

This fixes it, by using the ascii crate.

Thanks to @sterni for noticing.

Change-Id: I50b6a588d99b34e677cb22968cf0dfd8b331d11c
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2457
Reviewed-by: Profpatsch <mail@profpatsch.de>
Tested-by: BuildkiteCI
This commit is contained in:
Profpatsch 2021-01-29 16:35:02 +01:00
parent cf3aab3b78
commit f0579313d3
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
users/Profpatsch/rust-crates.nix
View file

@ -14,6 +14,13 @@ rec {
sha256 = "12q71z6ck8wlqrwgi25x3lrryyks9djymswn9b1c6qq0i01jpc1p";
};
ascii = pkgs.buildRustCrate {
pname = "ascii";
crateName = "ascii";
version = "1.0.0";
sha256 = "0gam8xsn981wfa40srsniivffjsfz1pg0xnigmczk9k7azb1ks1m";
};
regex-syntax = pkgs.buildRustCrate {
pname = "regex-syntax";
crateName = "regex-syntax";