maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Detect and reject mutually-referential outputs

Browse source 
There is probably a more efficient way to do this.
This commit is contained in:
Shea Levy 2011-12-21 17:14:28 +00:00
parent b19a0f63db
commit f3c88f297d
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/libstore/build.cc
View file

@ -1986,6 +1986,15 @@ void DerivationGoal::computeClosure()
info.deriver = drvPath;
infos.push_back(info);
}
/* Mutually recursive outputs are not allowed */
foreach (ValidPathInfos::iterator, i, infos)
foreach (ValidPathInfos::iterator, j, infos)
if ((i->path != j->path) &&
(i->references.find(j->path) != i->references.end()) &&
(j->references.find(i->path) != j->references.end()))
throw BuildError(format("Mutually referential outputs are not allowed: outputs `%1%' and `%2%' refer to each other") % i->path % j->path);
worker.store.registerValidPaths(infos);
/* It is now safe to delete the lock files, since all future