From f3f20c2080f1721d099d0c472740763ee062543a Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 26 Oct 2024 10:36:37 +0200 Subject: [PATCH] fix(users/flokli/slides/2023-nixcon): fix pdf gen reveal-md didn't exit with a nonzero exit code and just didn't contain the PDF. Fix this. Change-Id: Ie4bc7cbf4b9117b0a672a3294e9e64fb13459247 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12683 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: flokli --- .../presentations/2023-09-09-nixcon-tvix/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix b/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix index 1ec0a0bd0..b50309b6c 100644 --- a/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix +++ b/users/flokli/presentations/2023-09-09-nixcon-tvix/default.nix @@ -18,9 +18,6 @@ stdenv.mkDerivation { fontDirectories = with pkgs; [ jetbrains-mono fira fira-code fira-mono lato ]; }; - PUPPETEER_EXECUTABLE_PATH = "${pkgs.chromium}/bin/chromium"; - PUPPETEER_SKIP_CHROMIUM_DOWNLOAD = "1"; - nativeBuildInputs = [ pkgs.reveal-md pkgs.graphviz ]; buildPhase = '' @@ -31,7 +28,10 @@ stdenv.mkDerivation { mkdir -p $out reveal-md --static $out presentation.md - reveal-md --print $out/slides.pdf presentation.md cp tvixbolt.webm $out + + CHROME_CONFIG_HOME=/build/.config reveal-md presentation.md --print $out/slides.pdf --puppeteer-chromium-executable="${pkgs.chromium}/bin/chromium" + # Above command doesn't fail on error, ensure file has been created + [[ -f "$out/slides.pdf" ]] || exit 1 ''; }