From f9ceebe03128c7b3636d39e7f7f7a9f47dc37fd6 Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Thu, 13 Mar 2025 07:40:36 +0100 Subject: [PATCH] docs(tvix/glue/builtins): drop TODO MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit builtins.filterSource and builtins.path itself are very short these days, and use the same underlying (private) helper function. Describing builtins.filterSource with builtins.path won't lead to less code, so this TODO can be dropped. Change-Id: I5457949136e19204b32c8182b6c89e66cc2183e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/13252 Reviewed-by: Domen Kožar Tested-by: BuildkiteCI Reviewed-by: Marijan Petričević Autosubmit: flokli --- tvix/glue/src/builtins/mod.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/tvix/glue/src/builtins/mod.rs b/tvix/glue/src/builtins/mod.rs index 6149423ac..99be955d2 100644 --- a/tvix/glue/src/builtins/mod.rs +++ b/tvix/glue/src/builtins/mod.rs @@ -49,7 +49,6 @@ pub fn add_import_builtins<'co, 'ro, 'env, IO>( eval_builder: tvix_eval::EvaluationBuilder<'co, 'ro, 'env, IO>, io: Rc, ) -> tvix_eval::EvaluationBuilder<'co, 'ro, 'env, IO> { - // TODO(raitobezarius): evaluate expressing filterSource as Nix code using path (b/372) eval_builder.add_builtins(import::import_builtins(io)) }