More Elisp linting

This should cover most of the remaining linting errors. After this, I expect
fewer than ten linting errors.
This commit is contained in:
William Carroll 2020-09-01 10:17:43 +01:00
parent a638e15c0d
commit fb5ec068dd
47 changed files with 1049 additions and 989 deletions

View file

@ -1,5 +1,9 @@
;;; display.el --- Working with single or multiple displays -*- lexical-binding: t -*-
;; Author: William Carroll <wpcarro@gmail.com>
;; Version: 0.0.1
;; URL: https://git.wpcarro.dev/wpcarro/briefcase
;; Package-Requires: ((emacs "24"))
;;; Commentary:
;; Mostly wrappers around xrandr.
@ -24,15 +28,15 @@
;; Constants
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; TODO: Consider if this logic should be conditioned by `device/work-laptop?'.
(defconst display/laptop-monitor "eDP1"
;; TODO: Consider if this logic should be conditioned by `device-work-laptop?'.
(defconst display-laptop-monitor "eDP1"
"The xrandr identifier for my primary screen (on work laptop).")
;; TODO: Why is HDMI-1, eDP-1 sometimes and HDMI1, eDP1 other times.
(defconst display/4k-monitor "HDMI1"
(defconst display-4k-monitor "HDMI1"
"The xrandr identifer for my 4K monitor.")
(defconst display/display-states (cycle/from-list '((t . nil) (nil . t)))
(defconst display-display-states (cycle-from-list '((t . nil) (nil . t)))
"A list of cons cells modelling enabled and disabled states for my displays.
The car models the enabled state of my laptop display; the cdr models the
enabled state of my external monitor.")
@ -43,50 +47,50 @@ The car models the enabled state of my laptop display; the cdr models the
;; TODO: Debug why something this scales to 4k appropriately and other times it
;; doesn't.
(defun display/enable-4k ()
(defun display-enable-4k ()
"Attempt to connect to my 4K monitor."
(interactive)
(prelude-start-process
:name "display/enable-4k"
:name "display-enable-4k"
:command (string-format
"xrandr --output %s --above %s --primary --auto --size 3840x2160 --rate 30.00 --dpi 144"
display/4k-monitor
display/laptop-monitor)))
display-4k-monitor
display-laptop-monitor)))
(defun display/disable-4k ()
(defun display-disable-4k ()
"Disconnect from the 4K monitor."
(interactive)
(prelude-start-process
:name "display/disable-4k"
:name "display-disable-4k"
:command (string-format "xrandr --output %s --off"
display/4k-monitor)))
display-4k-monitor)))
(defun display/enable-laptop ()
(defun display-enable-laptop ()
"Turn the laptop monitor off.
Sometimes this is useful when I'm sharing my screen in a Google Hangout and I
only want to present one of my monitors."
(interactive)
(prelude-start-process
:name "display/disable-laptop"
:name "display-disable-laptop"
:command (string-format "xrandr --output %s --auto"
display/laptop-monitor)))
display-laptop-monitor)))
(defun display/disable-laptop ()
(defun display-disable-laptop ()
"Turn the laptop monitor off.
Sometimes this is useful when I'm sharing my screen in a Google Hangout and I
only want to present one of my monitors."
(interactive)
(prelude-start-process
:name "display/disable-laptop"
:name "display-disable-laptop"
:command (string-format "xrandr --output %s --off"
display/laptop-monitor)))
display-laptop-monitor)))
(defun display/cycle-display-states ()
"Cycle through `display/display-states' enabling and disabling displays."
(defun display-cycle-display-states ()
"Cycle through `display-display-states' enabling and disabling displays."
(interactive)
(let ((state (cycle/next display/display-states)))
(if (car state) (display/enable-laptop) (display/disable-laptop))
(if (cdr state) (display/enable-4k) (display/disable-4k))))
(let ((state (cycle-next display-display-states)))
(if (car state) (display-enable-laptop) (display-disable-laptop))
(if (cdr state) (display-enable-4k) (display-disable-4k))))
(provide 'display)
;;; display.el ends here