-- c99f979ad34f155fbeeea69b88bdc7458d89a21c by Derek Mauro <dmauro@google.com>: Remove a floating point division by zero test. This isn't testing behavior related to the library, and MSVC warns about it in opt mode. PiperOrigin-RevId: 285220804 -- 68b015491f0dbf1ab547994673281abd1f34cd4b by Gennadiy Rozental <rogeeff@google.com>: This CL introduces following changes to the class FlagImpl: * We eliminate the CommandLineFlagLocks struct. Instead callback guard and callback function are combined into a single CallbackData struct, while primary data lock is stored separately. * CallbackData member of class FlagImpl is initially set to be nullptr and is only allocated and initialized when a flag's callback is being set. For most flags we do not pay for the extra space and extra absl::Mutex now. * Primary data guard is stored in data_guard_ data member. This is a properly aligned character buffer of necessary size. During initialization of the flag we construct absl::Mutex in this space using placement new call. * We now avoid extra value copy after successful attempt to parse value out of string. Instead we swap flag's current value with tentative value we just produced. PiperOrigin-RevId: 285132636 -- ed45d118fb818969eb13094cf7827c885dfc562c by Tom Manshreck <shreck@google.com>: Change null-term* (and nul-term*) to NUL-term* in comments PiperOrigin-RevId: 285036610 -- 729619017944db895ce8d6d29c1995aa2e5628a5 by Derek Mauro <dmauro@google.com>: Use the Posix implementation of thread identity on MinGW. Some versions of MinGW suffer from thread_local bugs. PiperOrigin-RevId: 285022920 -- 39a25493503c76885bc3254c28f66a251c5b5bb0 by Greg Falcon <gfalcon@google.com>: Implementation detail change. Add further ABSL_NAMESPACE_BEGIN and _END annotation macros to files in Abseil. PiperOrigin-RevId: 285012012 GitOrigin-RevId: c99f979ad34f155fbeeea69b88bdc7458d89a21c Change-Id: I4c85d3704e45d11a9ac50d562f39640a6adbedc1
		
			
				
	
	
		
			430 lines
		
	
	
	
		
			12 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			430 lines
		
	
	
	
		
			12 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| // Copyright 2018 The Abseil Authors.
 | |
| //
 | |
| // Licensed under the Apache License, Version 2.0 (the "License");
 | |
| // you may not use this file except in compliance with the License.
 | |
| // You may obtain a copy of the License at
 | |
| //
 | |
| //      https://www.apache.org/licenses/LICENSE-2.0
 | |
| //
 | |
| // Unless required by applicable law or agreed to in writing, software
 | |
| // distributed under the License is distributed on an "AS IS" BASIS,
 | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| // See the License for the specific language governing permissions and
 | |
| // limitations under the License.
 | |
| 
 | |
| #include <limits>
 | |
| #include <scoped_allocator>
 | |
| 
 | |
| #include "gtest/gtest.h"
 | |
| #include "absl/container/internal/raw_hash_set.h"
 | |
| #include "absl/container/internal/tracked.h"
 | |
| 
 | |
| namespace absl {
 | |
| ABSL_NAMESPACE_BEGIN
 | |
| namespace container_internal {
 | |
| namespace {
 | |
| 
 | |
| enum AllocSpec {
 | |
|   kPropagateOnCopy = 1,
 | |
|   kPropagateOnMove = 2,
 | |
|   kPropagateOnSwap = 4,
 | |
| };
 | |
| 
 | |
| struct AllocState {
 | |
|   size_t num_allocs = 0;
 | |
|   std::set<void*> owned;
 | |
| };
 | |
| 
 | |
| template <class T,
 | |
|           int Spec = kPropagateOnCopy | kPropagateOnMove | kPropagateOnSwap>
 | |
| class CheckedAlloc {
 | |
|  public:
 | |
|   template <class, int>
 | |
|   friend class CheckedAlloc;
 | |
| 
 | |
|   using value_type = T;
 | |
| 
 | |
|   CheckedAlloc() {}
 | |
|   explicit CheckedAlloc(size_t id) : id_(id) {}
 | |
|   CheckedAlloc(const CheckedAlloc&) = default;
 | |
|   CheckedAlloc& operator=(const CheckedAlloc&) = default;
 | |
| 
 | |
|   template <class U>
 | |
|   CheckedAlloc(const CheckedAlloc<U, Spec>& that)
 | |
|       : id_(that.id_), state_(that.state_) {}
 | |
| 
 | |
|   template <class U>
 | |
|   struct rebind {
 | |
|     using other = CheckedAlloc<U, Spec>;
 | |
|   };
 | |
| 
 | |
|   using propagate_on_container_copy_assignment =
 | |
|       std::integral_constant<bool, (Spec & kPropagateOnCopy) != 0>;
 | |
| 
 | |
|   using propagate_on_container_move_assignment =
 | |
|       std::integral_constant<bool, (Spec & kPropagateOnMove) != 0>;
 | |
| 
 | |
|   using propagate_on_container_swap =
 | |
|       std::integral_constant<bool, (Spec & kPropagateOnSwap) != 0>;
 | |
| 
 | |
|   CheckedAlloc select_on_container_copy_construction() const {
 | |
|     if (Spec & kPropagateOnCopy) return *this;
 | |
|     return {};
 | |
|   }
 | |
| 
 | |
|   T* allocate(size_t n) {
 | |
|     T* ptr = std::allocator<T>().allocate(n);
 | |
|     track_alloc(ptr);
 | |
|     return ptr;
 | |
|   }
 | |
|   void deallocate(T* ptr, size_t n) {
 | |
|     memset(ptr, 0, n * sizeof(T));  // The freed memory must be unpoisoned.
 | |
|     track_dealloc(ptr);
 | |
|     return std::allocator<T>().deallocate(ptr, n);
 | |
|   }
 | |
| 
 | |
|   friend bool operator==(const CheckedAlloc& a, const CheckedAlloc& b) {
 | |
|     return a.id_ == b.id_;
 | |
|   }
 | |
|   friend bool operator!=(const CheckedAlloc& a, const CheckedAlloc& b) {
 | |
|     return !(a == b);
 | |
|   }
 | |
| 
 | |
|   size_t num_allocs() const { return state_->num_allocs; }
 | |
| 
 | |
|   void swap(CheckedAlloc& that) {
 | |
|     using std::swap;
 | |
|     swap(id_, that.id_);
 | |
|     swap(state_, that.state_);
 | |
|   }
 | |
| 
 | |
|   friend void swap(CheckedAlloc& a, CheckedAlloc& b) { a.swap(b); }
 | |
| 
 | |
|   friend std::ostream& operator<<(std::ostream& o, const CheckedAlloc& a) {
 | |
|     return o << "alloc(" << a.id_ << ")";
 | |
|   }
 | |
| 
 | |
|  private:
 | |
|   void track_alloc(void* ptr) {
 | |
|     AllocState* state = state_.get();
 | |
|     ++state->num_allocs;
 | |
|     if (!state->owned.insert(ptr).second)
 | |
|       ADD_FAILURE() << *this << " got previously allocated memory: " << ptr;
 | |
|   }
 | |
|   void track_dealloc(void* ptr) {
 | |
|     if (state_->owned.erase(ptr) != 1)
 | |
|       ADD_FAILURE() << *this
 | |
|                     << " deleting memory owned by another allocator: " << ptr;
 | |
|   }
 | |
| 
 | |
|   size_t id_ = std::numeric_limits<size_t>::max();
 | |
| 
 | |
|   std::shared_ptr<AllocState> state_ = std::make_shared<AllocState>();
 | |
| };
 | |
| 
 | |
| struct Identity {
 | |
|   int32_t operator()(int32_t v) const { return v; }
 | |
| };
 | |
| 
 | |
| struct Policy {
 | |
|   using slot_type = Tracked<int32_t>;
 | |
|   using init_type = Tracked<int32_t>;
 | |
|   using key_type = int32_t;
 | |
| 
 | |
|   template <class allocator_type, class... Args>
 | |
|   static void construct(allocator_type* alloc, slot_type* slot,
 | |
|                         Args&&... args) {
 | |
|     std::allocator_traits<allocator_type>::construct(
 | |
|         *alloc, slot, std::forward<Args>(args)...);
 | |
|   }
 | |
| 
 | |
|   template <class allocator_type>
 | |
|   static void destroy(allocator_type* alloc, slot_type* slot) {
 | |
|     std::allocator_traits<allocator_type>::destroy(*alloc, slot);
 | |
|   }
 | |
| 
 | |
|   template <class allocator_type>
 | |
|   static void transfer(allocator_type* alloc, slot_type* new_slot,
 | |
|                        slot_type* old_slot) {
 | |
|     construct(alloc, new_slot, std::move(*old_slot));
 | |
|     destroy(alloc, old_slot);
 | |
|   }
 | |
| 
 | |
|   template <class F>
 | |
|   static auto apply(F&& f, int32_t v) -> decltype(std::forward<F>(f)(v, v)) {
 | |
|     return std::forward<F>(f)(v, v);
 | |
|   }
 | |
| 
 | |
|   template <class F>
 | |
|   static auto apply(F&& f, const slot_type& v)
 | |
|       -> decltype(std::forward<F>(f)(v.val(), v)) {
 | |
|     return std::forward<F>(f)(v.val(), v);
 | |
|   }
 | |
| 
 | |
|   template <class F>
 | |
|   static auto apply(F&& f, slot_type&& v)
 | |
|       -> decltype(std::forward<F>(f)(v.val(), std::move(v))) {
 | |
|     return std::forward<F>(f)(v.val(), std::move(v));
 | |
|   }
 | |
| 
 | |
|   static slot_type& element(slot_type* slot) { return *slot; }
 | |
| };
 | |
| 
 | |
| template <int Spec>
 | |
| struct PropagateTest : public ::testing::Test {
 | |
|   using Alloc = CheckedAlloc<Tracked<int32_t>, Spec>;
 | |
| 
 | |
|   using Table = raw_hash_set<Policy, Identity, std::equal_to<int32_t>, Alloc>;
 | |
| 
 | |
|   PropagateTest() {
 | |
|     EXPECT_EQ(a1, t1.get_allocator());
 | |
|     EXPECT_NE(a2, t1.get_allocator());
 | |
|   }
 | |
| 
 | |
|   Alloc a1 = Alloc(1);
 | |
|   Table t1 = Table(0, a1);
 | |
|   Alloc a2 = Alloc(2);
 | |
| };
 | |
| 
 | |
| using PropagateOnAll =
 | |
|     PropagateTest<kPropagateOnCopy | kPropagateOnMove | kPropagateOnSwap>;
 | |
| using NoPropagateOnCopy = PropagateTest<kPropagateOnMove | kPropagateOnSwap>;
 | |
| using NoPropagateOnMove = PropagateTest<kPropagateOnCopy | kPropagateOnSwap>;
 | |
| 
 | |
| TEST_F(PropagateOnAll, Empty) { EXPECT_EQ(0, a1.num_allocs()); }
 | |
| 
 | |
| TEST_F(PropagateOnAll, InsertAllocates) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, InsertDecomposes) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| 
 | |
|   EXPECT_FALSE(t1.insert(0).second);
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, RehashMoves) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   t1.rehash(2 * t1.capacity());
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   it = t1.find(0);
 | |
|   EXPECT_EQ(1, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, CopyConstructor) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1);
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnCopy, CopyConstructor) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1);
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, u.get_allocator().num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, CopyConstructorWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1, a1);
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnCopy, CopyConstructorWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1, a1);
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, CopyConstructorWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1, a2);
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnCopy, CopyConstructorWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(t1, a2);
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, MoveConstructor) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1));
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnMove, MoveConstructor) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1));
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, MoveConstructorWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1), a1);
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnMove, MoveConstructorWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1), a1);
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, MoveConstructorWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1), a2);
 | |
|   it = u.find(0);
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(1, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnMove, MoveConstructorWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(std::move(t1), a2);
 | |
|   it = u.find(0);
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(1, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, CopyAssignmentWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a1);
 | |
|   u = t1;
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnCopy, CopyAssignmentWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a1);
 | |
|   u = t1;
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, CopyAssignmentWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a2);
 | |
|   u = t1;
 | |
|   EXPECT_EQ(a1, u.get_allocator());
 | |
|   EXPECT_EQ(2, a1.num_allocs());
 | |
|   EXPECT_EQ(0, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnCopy, CopyAssignmentWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a2);
 | |
|   u = t1;
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(1, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, MoveAssignmentWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a1);
 | |
|   u = std::move(t1);
 | |
|   EXPECT_EQ(a1, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnMove, MoveAssignmentWithSameAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a1);
 | |
|   u = std::move(t1);
 | |
|   EXPECT_EQ(a1, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, MoveAssignmentWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a2);
 | |
|   u = std::move(t1);
 | |
|   EXPECT_EQ(a1, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(NoPropagateOnMove, MoveAssignmentWithDifferentAlloc) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a2);
 | |
|   u = std::move(t1);
 | |
|   it = u.find(0);
 | |
|   EXPECT_EQ(a2, u.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(1, a2.num_allocs());
 | |
|   EXPECT_EQ(1, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| TEST_F(PropagateOnAll, Swap) {
 | |
|   auto it = t1.insert(0).first;
 | |
|   Table u(0, a2);
 | |
|   u.swap(t1);
 | |
|   EXPECT_EQ(a1, u.get_allocator());
 | |
|   EXPECT_EQ(a2, t1.get_allocator());
 | |
|   EXPECT_EQ(1, a1.num_allocs());
 | |
|   EXPECT_EQ(0, a2.num_allocs());
 | |
|   EXPECT_EQ(0, it->num_moves());
 | |
|   EXPECT_EQ(0, it->num_copies());
 | |
| }
 | |
| 
 | |
| }  // namespace
 | |
| }  // namespace container_internal
 | |
| ABSL_NAMESPACE_END
 | |
| }  // namespace absl
 |