52bb3c6d02
This allows specifying an url in place of a named reference to another composition entry, if the castore crate has been compiled with the xp-store-composition feature. Example: `--directory-service-addr cache://?near=memory://&far=memory://` This would be equivalent to the instantiation via toml file: ```toml [memory1] type = "memory" [memory2] type = "memory" [default] type = "cache" near = "memory1" far = "memory2" ``` Note that each anonymous url causes a distinct instance to be created. Change-Id: Iee5a07a94b063b5e767c704d9cad0114fa843164 Reviewed-on: https://cl.tvl.fyi/c/depot/+/12146 Reviewed-by: flokli <flokli@flokli.de> Tested-by: BuildkiteCI
88 lines
3.6 KiB
Rust
88 lines
3.6 KiB
Rust
use std::sync::Arc;
|
|
|
|
use url::Url;
|
|
|
|
use crate::composition::{
|
|
with_registry, CompositionContext, DeserializeWithRegistry, ServiceBuilder, REG,
|
|
};
|
|
|
|
use super::BlobService;
|
|
|
|
/// Constructs a new instance of a [BlobService] from an URI.
|
|
///
|
|
/// The following schemes are supported by the following services:
|
|
/// - `memory://` ([MemoryBlobService])
|
|
/// - `grpc+*://` ([GRPCBlobService])
|
|
/// - `objectstore+*://` ([ObjectStoreBlobService])
|
|
///
|
|
/// See their `from_url` methods for more details about their syntax.
|
|
pub async fn from_addr(
|
|
uri: &str,
|
|
) -> Result<Arc<dyn BlobService>, Box<dyn std::error::Error + Send + Sync>> {
|
|
let url = Url::parse(uri)
|
|
.map_err(|e| crate::Error::StorageError(format!("unable to parse url: {}", e)))?;
|
|
|
|
let blob_service_config = with_registry(®, || {
|
|
<DeserializeWithRegistry<Box<dyn ServiceBuilder<Output = dyn BlobService>>>>::try_from(url)
|
|
})?
|
|
.0;
|
|
let blob_service = blob_service_config
|
|
.build("anonymous", &CompositionContext::blank(®))
|
|
.await?;
|
|
|
|
Ok(blob_service)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::from_addr;
|
|
use rstest::rstest;
|
|
|
|
#[rstest]
|
|
/// This uses an unsupported scheme.
|
|
#[case::unsupported_scheme("http://foo.example/test", false)]
|
|
/// This correctly sets the scheme, and doesn't set a path.
|
|
#[case::memory_valid("memory://", true)]
|
|
/// This sets a memory url host to `foo`
|
|
#[case::memory_invalid_host("memory://foo", false)]
|
|
/// This sets a memory url path to "/", which is invalid.
|
|
#[case::memory_invalid_root_path("memory:///", false)]
|
|
/// This sets a memory url path to "/foo", which is invalid.
|
|
#[case::memory_invalid_root_path_foo("memory:///foo", false)]
|
|
/// Correct scheme to connect to a unix socket.
|
|
#[case::grpc_valid_unix_socket("grpc+unix:///path/to/somewhere", true)]
|
|
/// Correct scheme for unix socket, but setting a host too, which is invalid.
|
|
#[case::grpc_invalid_unix_socket_and_host("grpc+unix://host.example/path/to/somewhere", false)]
|
|
/// Correct scheme to connect to localhost, with port 12345
|
|
#[case::grpc_valid_ipv6_localhost_port_12345("grpc+http://[::1]:12345", true)]
|
|
/// Correct scheme to connect to localhost over http, without specifying a port.
|
|
#[case::grpc_valid_http_host_without_port("grpc+http://localhost", true)]
|
|
/// Correct scheme to connect to localhost over http, without specifying a port.
|
|
#[case::grpc_valid_https_host_without_port("grpc+https://localhost", true)]
|
|
/// Correct scheme to connect to localhost over http, but with additional path, which is invalid.
|
|
#[case::grpc_invalid_has_path("grpc+http://localhost/some-path", false)]
|
|
/// An example for object store (InMemory)
|
|
#[case::objectstore_valid_memory("objectstore+memory:///", true)]
|
|
/// An example for object store (LocalFileSystem)
|
|
#[case::objectstore_valid_file("objectstore+file:///foo/bar", true)]
|
|
// An example for object store (HTTP / WebDAV)
|
|
#[case::objectstore_valid_http_url("objectstore+https://localhost:8080/some-path", true)]
|
|
/// An example for object store (S3)
|
|
#[cfg_attr(
|
|
feature = "cloud",
|
|
case::objectstore_valid_s3_url("objectstore+s3://bucket/path", true)
|
|
)]
|
|
/// An example for object store (GCS)
|
|
#[cfg_attr(
|
|
feature = "cloud",
|
|
case::objectstore_valid_gcs_url("objectstore+gs://bucket/path", true)
|
|
)]
|
|
#[tokio::test]
|
|
async fn test_from_addr_tokio(#[case] uri_str: &str, #[case] exp_succeed: bool) {
|
|
if exp_succeed {
|
|
from_addr(uri_str).await.expect("should succeed");
|
|
} else {
|
|
assert!(from_addr(uri_str).await.is_err(), "should fail");
|
|
}
|
|
}
|
|
}
|