Passing a string directly to add_paths like this causes the proto class to take ownership over the string, meaning when it is destructed it will *explicitly* free the string. When the string's actual owner (the derivation struct) then goes out of scope it'll get freed again, causing a double-free. This fixes that to instead use the copy constructor to assign to a pointer to a new path, and covers the whole to_proto method with a rapidcheck test. Fixes: b/64 Change-Id: I84235bed9104ff430a0acf686d4a96f1e2e9a897 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2106 Reviewed-by: tazjin <mail@tazj.in> Tested-by: BuildkiteCI
175 lines
5.6 KiB
C++
175 lines
5.6 KiB
C++
#include "libstore/derivations.hh"
|
|
|
|
#include <memory>
|
|
|
|
#include <absl/strings/str_cat.h>
|
|
#include <gtest/gtest.h>
|
|
#include <rapidcheck.h>
|
|
#include <rapidcheck/Assertions.h>
|
|
#include <rapidcheck/gen/Arbitrary.h>
|
|
#include <rapidcheck/gen/Build.h>
|
|
#include <rapidcheck/gen/Container.h>
|
|
#include <rapidcheck/gen/Tuple.h>
|
|
#include <rapidcheck/gtest.h>
|
|
#include <rapidcheck/state.h>
|
|
|
|
#include "libexpr/eval.hh"
|
|
#include "libutil/hash.hh"
|
|
#include "libutil/types.hh"
|
|
|
|
namespace rc {
|
|
|
|
using nix::Derivation;
|
|
using nix::DerivationOutput;
|
|
|
|
template <class K, class V>
|
|
struct Arbitrary<absl::btree_map<K, V>> {
|
|
static Gen<absl::btree_map<K, V>> arbitrary() {
|
|
return gen::map(gen::arbitrary<std::map<K, V>>(), [](std::map<K, V> map) {
|
|
absl::btree_map<K, V> out_map;
|
|
out_map.insert(map.begin(), map.end());
|
|
return out_map;
|
|
});
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct Arbitrary<nix::Base> {
|
|
static Gen<nix::Base> arbitrary() {
|
|
return gen::element(nix::Base16, nix::Base32, nix::Base64);
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct Arbitrary<DerivationOutput> {
|
|
static Gen<DerivationOutput> arbitrary() {
|
|
return gen::apply(
|
|
[](std::string content, std::string path, std::string hash_algo,
|
|
bool recursive, bool include_algo_in_hash, nix::Base base) {
|
|
auto hash_type = nix::parseHashType(hash_algo);
|
|
auto hash = nix::hashString(hash_type, content);
|
|
return DerivationOutput(
|
|
path, recursive ? absl::StrCat("r:", hash_algo) : hash_algo,
|
|
hash.to_string(base, include_algo_in_hash));
|
|
},
|
|
gen::arbitrary<std::string>(),
|
|
gen::map(gen::arbitrary<std::string>(),
|
|
[](std::string s) { return absl::StrCat("/", s); }),
|
|
gen::element<std::string>("md5", "sha1", "sha256", "sha512"),
|
|
gen::arbitrary<bool>(), gen::arbitrary<bool>(),
|
|
gen::arbitrary<nix::Base>());
|
|
}
|
|
};
|
|
|
|
template <>
|
|
struct Arbitrary<Derivation> {
|
|
static Gen<Derivation> arbitrary() {
|
|
auto gen_path = gen::map(gen::arbitrary<std::string>(), [](std::string s) {
|
|
return absl::StrCat("/", s);
|
|
});
|
|
|
|
return gen::build<Derivation>(
|
|
gen::set(&nix::BasicDerivation::outputs),
|
|
gen::set(&nix::BasicDerivation::inputSrcs,
|
|
gen::container<nix::PathSet>(gen_path)),
|
|
gen::set(&nix::BasicDerivation::platform),
|
|
gen::set(&nix::BasicDerivation::builder, gen_path),
|
|
gen::set(&nix::BasicDerivation::args),
|
|
gen::set(&nix::BasicDerivation::env),
|
|
gen::set(&Derivation::inputDrvs,
|
|
gen::container<nix::DerivationInputs>(
|
|
gen_path, gen::arbitrary<nix::StringSet>())));
|
|
}
|
|
};
|
|
|
|
} // namespace rc
|
|
|
|
namespace nix {
|
|
|
|
void AssertDerivationsEqual(const Derivation& lhs, const Derivation& rhs) {
|
|
RC_ASSERT(lhs.outputs.size() == rhs.outputs.size());
|
|
for (const auto& [k, lhs_v] : lhs.outputs) {
|
|
auto rhs_v = rhs.outputs.find(k);
|
|
RC_ASSERT(rhs_v != rhs.outputs.end());
|
|
RC_ASSERT(lhs_v.path == rhs_v->second.path);
|
|
RC_ASSERT(lhs_v.hashAlgo == rhs_v->second.hashAlgo);
|
|
RC_ASSERT(lhs_v.hash == rhs_v->second.hash);
|
|
}
|
|
|
|
RC_ASSERT(lhs.inputSrcs == rhs.inputSrcs);
|
|
RC_ASSERT(lhs.platform == rhs.platform);
|
|
RC_ASSERT(lhs.builder == rhs.builder);
|
|
RC_ASSERT(lhs.args == rhs.args);
|
|
RC_ASSERT(lhs.env == rhs.env);
|
|
RC_ASSERT(lhs.inputDrvs == rhs.inputDrvs);
|
|
}
|
|
|
|
class DerivationsTest : public ::testing::Test {};
|
|
|
|
// NOLINTNEXTLINE
|
|
RC_GTEST_FIXTURE_PROP(DerivationsTest, UnparseParseRoundTrip,
|
|
(Derivation && drv)) {
|
|
auto unparsed = drv.unparse();
|
|
auto parsed = parseDerivation(unparsed);
|
|
AssertDerivationsEqual(drv, parsed);
|
|
}
|
|
|
|
// NOLINTNEXTLINE
|
|
RC_GTEST_FIXTURE_PROP(DerivationsTest, ToProtoPreservesInput,
|
|
(Derivation && drv)) {
|
|
auto proto = drv.to_proto();
|
|
|
|
RC_ASSERT(proto.outputs_size() == drv.outputs.size());
|
|
RC_ASSERT(proto.input_sources().paths_size() == drv.inputSrcs.size());
|
|
auto paths = proto.input_sources().paths();
|
|
for (const auto& input_src : drv.inputSrcs) {
|
|
RC_ASSERT(std::find(paths.begin(), paths.end(), input_src) != paths.end());
|
|
}
|
|
|
|
RC_ASSERT(proto.platform() == drv.platform);
|
|
RC_ASSERT(proto.builder().path() == drv.builder);
|
|
|
|
RC_ASSERT(proto.args_size() == drv.args.size());
|
|
auto args = proto.args();
|
|
for (const auto& arg : drv.args) {
|
|
RC_ASSERT(std::find(args.begin(), args.end(), arg) != args.end());
|
|
}
|
|
|
|
RC_ASSERT(proto.env_size() == drv.env.size());
|
|
auto env = proto.env();
|
|
for (const auto& [key, value] : drv.env) {
|
|
RC_ASSERT(env.at(key) == value);
|
|
}
|
|
}
|
|
|
|
class ParseDrvPathWithOutputsTest : public DerivationsTest {};
|
|
|
|
TEST(ParseDrvPathWithOutputsTest, ParseDrvPathWithOutputs) {
|
|
auto input = "/nix/store/my51f75kp056md84gq2v08pd140pcz57-test.drv!out";
|
|
auto result = nix::parseDrvPathWithOutputs(input);
|
|
|
|
ASSERT_EQ(result.first,
|
|
"/nix/store/my51f75kp056md84gq2v08pd140pcz57-test.drv");
|
|
ASSERT_EQ(result.second, nix::PathSet{"out"});
|
|
}
|
|
|
|
TEST(ParseDrvPathWithOutputsTest, ParseDrvPathWithMultipleOutputs) {
|
|
auto input = "/nix/store/my51f75kp056md84gq2v08pd140pcz57-test.drv!out,dev";
|
|
auto result = nix::parseDrvPathWithOutputs(input);
|
|
|
|
nix::PathSet expected = {"out", "dev"};
|
|
|
|
ASSERT_EQ(result.first,
|
|
"/nix/store/my51f75kp056md84gq2v08pd140pcz57-test.drv");
|
|
ASSERT_EQ(result.second, expected);
|
|
}
|
|
|
|
TEST(ParseDrvPathWithOutputsTest, ParseDrvPathWithNoOutputs) {
|
|
auto input = "/nix/store/my51f75kp056md84gq2v08pd140pcz57-test";
|
|
auto result = nix::parseDrvPathWithOutputs(input);
|
|
|
|
ASSERT_EQ(result.first, "/nix/store/my51f75kp056md84gq2v08pd140pcz57-test");
|
|
ASSERT_EQ(result.second, nix::PathSet());
|
|
}
|
|
|
|
} // namespace nix
|