dfe137786c
Make constructing of a new Evaluation use the builder pattern rather than setting public mutable fields. This is currently a pure refactor (no functionality has changed) but has a few advantages: - We've encapsulated the internals of the fields in Evaluation, meaning we can change them without too much breakage of clients - We have type safety that prevents us from ever changing the fields of an Evaluation after it's built (which matters more in a world where we reuse Evaluations). More importantly, this paves the road for doing different things with the construction of an Evaluation - notably, sharing certain things like the GlobalsMap across subsequent evaluations in eg the REPL. Fixes: b/262 Change-Id: I4a27116faac14cdd144fc7c992d14ae095a1aca4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11956 Tested-by: BuildkiteCI Autosubmit: aspen <root@gws.fyi> Reviewed-by: flokli <flokli@flokli.de>
39 lines
932 B
Rust
39 lines
932 B
Rust
use crate::*;
|
|
|
|
#[test]
|
|
fn test_source_builtin() {
|
|
// Test an evaluation with a source-only builtin. The test ensures
|
|
// that the artificially constructed thunking is correct.
|
|
|
|
let eval = Evaluation::builder_pure()
|
|
.add_src_builtin("testSourceBuiltin", "42")
|
|
.build();
|
|
|
|
let result = eval.evaluate("builtins.testSourceBuiltin", None);
|
|
assert!(
|
|
result.errors.is_empty(),
|
|
"evaluation failed: {:?}",
|
|
result.errors
|
|
);
|
|
|
|
let value = result.value.unwrap();
|
|
assert!(
|
|
matches!(value, Value::Integer(42)),
|
|
"expected the integer 42, but got {}",
|
|
value,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn skip_broken_bytecode() {
|
|
let result = Evaluation::builder_pure()
|
|
.build()
|
|
.evaluate(/* code = */ "x", None);
|
|
|
|
assert_eq!(result.errors.len(), 1);
|
|
|
|
assert!(matches!(
|
|
result.errors[0].kind,
|
|
ErrorKind::UnknownStaticVariable
|
|
));
|
|
}
|