No description
9a8a9c6b67
This prevents framing confusion, which would otherwise lead to a trivial confused deputy attack. See issue #120. The NixFramedReader state machine has been refactored to simplify its internal logic and accurately account for EOF conditions. End-of-stream is fused, and unexpected EOF on the underlying reader is returned as UnexpectedEof, though we don't fuse those ourselves. We also ensure that the underlying reader does not swap the ReadBuf; this would otherwise supply a primitive for converting uninitialised mutable memory into `&mut [u8]` without initialisation, thus allowing undefined behaviour to be triggered from safe code. Change-Id: I05ddb7e3ca57b3363f56c0d9b43d5a641748ca36 Reviewed-on: https://cl.snix.dev/c/snix/+/30380 Reviewed-by: Brian Olsen <brian@maven-group.org> Tested-by: besadii Reviewed-by: Florian Klink <flokli@flokli.de> |
||
|---|---|---|
| .gcroots | ||
| .nixery | ||
| contrib | ||
| fun/clbot | ||
| nix | ||
| ops | ||
| snix | ||
| third_party | ||
| tools | ||
| web | ||
| .editorconfig | ||
| .envrc | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .gitreview | ||
| .hgignore | ||
| .mailmap | ||
| .rgignore | ||
| buf.gen.yaml | ||
| buf.yaml | ||
| default.nix | ||
| LICENSE | ||
| OWNERS | ||
| README.md | ||
| RULES | ||
| rustfmt.toml | ||