-- c99f979ad34f155fbeeea69b88bdc7458d89a21c by Derek Mauro <dmauro@google.com>: Remove a floating point division by zero test. This isn't testing behavior related to the library, and MSVC warns about it in opt mode. PiperOrigin-RevId: 285220804 -- 68b015491f0dbf1ab547994673281abd1f34cd4b by Gennadiy Rozental <rogeeff@google.com>: This CL introduces following changes to the class FlagImpl: * We eliminate the CommandLineFlagLocks struct. Instead callback guard and callback function are combined into a single CallbackData struct, while primary data lock is stored separately. * CallbackData member of class FlagImpl is initially set to be nullptr and is only allocated and initialized when a flag's callback is being set. For most flags we do not pay for the extra space and extra absl::Mutex now. * Primary data guard is stored in data_guard_ data member. This is a properly aligned character buffer of necessary size. During initialization of the flag we construct absl::Mutex in this space using placement new call. * We now avoid extra value copy after successful attempt to parse value out of string. Instead we swap flag's current value with tentative value we just produced. PiperOrigin-RevId: 285132636 -- ed45d118fb818969eb13094cf7827c885dfc562c by Tom Manshreck <shreck@google.com>: Change null-term* (and nul-term*) to NUL-term* in comments PiperOrigin-RevId: 285036610 -- 729619017944db895ce8d6d29c1995aa2e5628a5 by Derek Mauro <dmauro@google.com>: Use the Posix implementation of thread identity on MinGW. Some versions of MinGW suffer from thread_local bugs. PiperOrigin-RevId: 285022920 -- 39a25493503c76885bc3254c28f66a251c5b5bb0 by Greg Falcon <gfalcon@google.com>: Implementation detail change. Add further ABSL_NAMESPACE_BEGIN and _END annotation macros to files in Abseil. PiperOrigin-RevId: 285012012 GitOrigin-RevId: c99f979ad34f155fbeeea69b88bdc7458d89a21c Change-Id: I4c85d3704e45d11a9ac50d562f39640a6adbedc1
		
			
				
	
	
		
			180 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			180 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
// Copyright 2017 The Abseil Authors.
 | 
						|
//
 | 
						|
// Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
// you may not use this file except in compliance with the License.
 | 
						|
// You may obtain a copy of the License at
 | 
						|
//
 | 
						|
//      https://www.apache.org/licenses/LICENSE-2.0
 | 
						|
//
 | 
						|
// Unless required by applicable law or agreed to in writing, software
 | 
						|
// distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
// See the License for the specific language governing permissions and
 | 
						|
// limitations under the License.
 | 
						|
 | 
						|
#include "absl/synchronization/internal/per_thread_sem.h"
 | 
						|
 | 
						|
#include <atomic>
 | 
						|
#include <condition_variable>  // NOLINT(build/c++11)
 | 
						|
#include <functional>
 | 
						|
#include <limits>
 | 
						|
#include <mutex>               // NOLINT(build/c++11)
 | 
						|
#include <string>
 | 
						|
#include <thread>              // NOLINT(build/c++11)
 | 
						|
 | 
						|
#include "gtest/gtest.h"
 | 
						|
#include "absl/base/internal/cycleclock.h"
 | 
						|
#include "absl/base/internal/thread_identity.h"
 | 
						|
#include "absl/strings/str_cat.h"
 | 
						|
#include "absl/time/clock.h"
 | 
						|
#include "absl/time/time.h"
 | 
						|
 | 
						|
// In this test we explicitly avoid the use of synchronization
 | 
						|
// primitives which might use PerThreadSem, most notably absl::Mutex.
 | 
						|
 | 
						|
namespace absl {
 | 
						|
ABSL_NAMESPACE_BEGIN
 | 
						|
namespace synchronization_internal {
 | 
						|
 | 
						|
class SimpleSemaphore {
 | 
						|
 public:
 | 
						|
  SimpleSemaphore() : count_(0) {}
 | 
						|
 | 
						|
  // Decrements (locks) the semaphore. If the semaphore's value is
 | 
						|
  // greater than zero, then the decrement proceeds, and the function
 | 
						|
  // returns, immediately. If the semaphore currently has the value
 | 
						|
  // zero, then the call blocks until it becomes possible to perform
 | 
						|
  // the decrement.
 | 
						|
  void Wait() {
 | 
						|
    std::unique_lock<std::mutex> lock(mu_);
 | 
						|
    cv_.wait(lock, [this]() { return count_ > 0; });
 | 
						|
    --count_;
 | 
						|
    cv_.notify_one();
 | 
						|
  }
 | 
						|
 | 
						|
  // Increments (unlocks) the semaphore. If the semaphore's value
 | 
						|
  // consequently becomes greater than zero, then another thread
 | 
						|
  // blocked Wait() call will be woken up and proceed to lock the
 | 
						|
  // semaphore.
 | 
						|
  void Post() {
 | 
						|
    std::lock_guard<std::mutex> lock(mu_);
 | 
						|
    ++count_;
 | 
						|
    cv_.notify_one();
 | 
						|
  }
 | 
						|
 | 
						|
 private:
 | 
						|
  std::mutex mu_;
 | 
						|
  std::condition_variable cv_;
 | 
						|
  int count_;
 | 
						|
};
 | 
						|
 | 
						|
struct ThreadData {
 | 
						|
  int num_iterations;                 // Number of replies to send.
 | 
						|
  SimpleSemaphore identity2_written;  // Posted by thread writing identity2.
 | 
						|
  base_internal::ThreadIdentity *identity1;  // First Post()-er.
 | 
						|
  base_internal::ThreadIdentity *identity2;  // First Wait()-er.
 | 
						|
  KernelTimeout timeout;
 | 
						|
};
 | 
						|
 | 
						|
// Need friendship with PerThreadSem.
 | 
						|
class PerThreadSemTest : public testing::Test {
 | 
						|
 public:
 | 
						|
  static void TimingThread(ThreadData* t) {
 | 
						|
    t->identity2 = GetOrCreateCurrentThreadIdentity();
 | 
						|
    t->identity2_written.Post();
 | 
						|
    while (t->num_iterations--) {
 | 
						|
      Wait(t->timeout);
 | 
						|
      Post(t->identity1);
 | 
						|
    }
 | 
						|
  }
 | 
						|
 | 
						|
  void TestTiming(const char *msg, bool timeout) {
 | 
						|
    static const int kNumIterations = 100;
 | 
						|
    ThreadData t;
 | 
						|
    t.num_iterations = kNumIterations;
 | 
						|
    t.timeout = timeout ?
 | 
						|
        KernelTimeout(absl::Now() + absl::Seconds(10000))  // far in the future
 | 
						|
        : KernelTimeout::Never();
 | 
						|
    t.identity1 = GetOrCreateCurrentThreadIdentity();
 | 
						|
 | 
						|
    // We can't use the Thread class here because it uses the Mutex
 | 
						|
    // class which will invoke PerThreadSem, so we use std::thread instead.
 | 
						|
    std::thread partner_thread(std::bind(TimingThread, &t));
 | 
						|
 | 
						|
    // Wait for our partner thread to register their identity.
 | 
						|
    t.identity2_written.Wait();
 | 
						|
 | 
						|
    int64_t min_cycles = std::numeric_limits<int64_t>::max();
 | 
						|
    int64_t total_cycles = 0;
 | 
						|
    for (int i = 0; i < kNumIterations; ++i) {
 | 
						|
      absl::SleepFor(absl::Milliseconds(20));
 | 
						|
      int64_t cycles = base_internal::CycleClock::Now();
 | 
						|
      Post(t.identity2);
 | 
						|
      Wait(t.timeout);
 | 
						|
      cycles = base_internal::CycleClock::Now() - cycles;
 | 
						|
      min_cycles = std::min(min_cycles, cycles);
 | 
						|
      total_cycles += cycles;
 | 
						|
    }
 | 
						|
    std::string out = StrCat(
 | 
						|
        msg, "min cycle count=", min_cycles, " avg cycle count=",
 | 
						|
        absl::SixDigits(static_cast<double>(total_cycles) / kNumIterations));
 | 
						|
    printf("%s\n", out.c_str());
 | 
						|
 | 
						|
    partner_thread.join();
 | 
						|
  }
 | 
						|
 | 
						|
 protected:
 | 
						|
  static void Post(base_internal::ThreadIdentity *id) {
 | 
						|
    PerThreadSem::Post(id);
 | 
						|
  }
 | 
						|
  static bool Wait(KernelTimeout t) {
 | 
						|
    return PerThreadSem::Wait(t);
 | 
						|
  }
 | 
						|
 | 
						|
  // convenience overload
 | 
						|
  static bool Wait(absl::Time t) {
 | 
						|
    return Wait(KernelTimeout(t));
 | 
						|
  }
 | 
						|
 | 
						|
  static void Tick(base_internal::ThreadIdentity *identity) {
 | 
						|
    PerThreadSem::Tick(identity);
 | 
						|
  }
 | 
						|
};
 | 
						|
 | 
						|
namespace {
 | 
						|
 | 
						|
TEST_F(PerThreadSemTest, WithoutTimeout) {
 | 
						|
  PerThreadSemTest::TestTiming("Without timeout: ", false);
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(PerThreadSemTest, WithTimeout) {
 | 
						|
  PerThreadSemTest::TestTiming("With timeout:    ", true);
 | 
						|
}
 | 
						|
 | 
						|
TEST_F(PerThreadSemTest, Timeouts) {
 | 
						|
  const absl::Duration delay = absl::Milliseconds(50);
 | 
						|
  const absl::Time start = absl::Now();
 | 
						|
  EXPECT_FALSE(Wait(start + delay));
 | 
						|
  const absl::Duration elapsed = absl::Now() - start;
 | 
						|
  // Allow for a slight early return, to account for quality of implementation
 | 
						|
  // issues on various platforms.
 | 
						|
  const absl::Duration slop = absl::Microseconds(200);
 | 
						|
  EXPECT_LE(delay - slop, elapsed)
 | 
						|
      << "Wait returned " << delay - elapsed
 | 
						|
      << " early (with " << slop << " slop), start time was " << start;
 | 
						|
 | 
						|
  absl::Time negative_timeout = absl::UnixEpoch() - absl::Milliseconds(100);
 | 
						|
  EXPECT_FALSE(Wait(negative_timeout));
 | 
						|
  EXPECT_LE(negative_timeout, absl::Now() + slop);  // trivially true :)
 | 
						|
 | 
						|
  Post(GetOrCreateCurrentThreadIdentity());
 | 
						|
  // The wait here has an expired timeout, but we have a wake to consume,
 | 
						|
  // so this should succeed
 | 
						|
  EXPECT_TRUE(Wait(negative_timeout));
 | 
						|
}
 | 
						|
 | 
						|
}  // namespace
 | 
						|
 | 
						|
}  // namespace synchronization_internal
 | 
						|
ABSL_NAMESPACE_END
 | 
						|
}  // namespace absl
 |