maurice/snix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
snix/third_party/nix/src/libexpr
History
Kane York a5dae62e85 fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 
The behavior to return a list containing a single empty string when
provided an empty string is a behavior that absl inherited from legacy
code. However, the behavior expected by legacy code in Nix is the
behavior provided by the SkipEmpty option. Switch all calls to use
SkipEmpty, except for the call already using SkipWhitespace.

See also commit 26a59482d2, with the
partly-prophetic message: "there may be other places we need to
fix this as well."

Change-Id: I6e94856a12cfb1b7e4a3b4e221769ed446648861
Reviewed-on: https://cl.tvl.fyi/c/depot/+/1687
Tested-by: BuildkiteCI
Reviewed-by: glittershark <grfn@gws.fyi>
2020-08-06 20:50:47 +00:00
..
primops fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 2020-08-06 20:50:47 +00:00
attr-path.cc fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
attr-path.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
attr-set.cc refactor(3p/nix): Rename & undeprecate Bindings::lexicographicOrder 2020-07-19 19:02:06 +00:00
attr-set.hh fix(3p/nix/expr): use traceable_allocator for btree_map 2020-08-01 21:16:29 +00:00
CMakeLists.txt chore(3p/nix/libexpr): Cleanups and notes in eval.cc 2020-08-01 18:54:50 +00:00
common-eval-args.cc feat(3p/nix): Statically pass bindings capacity where possible 2020-07-13 23:50:24 +00:00
common-eval-args.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
eval-inline.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
eval.cc feat(3p/nix): add --trace-file-access to nix-instantiate 2020-08-05 22:49:22 +00:00
eval.hh feat(3p/nix): add --trace-file-access to nix-instantiate 2020-08-05 22:49:22 +00:00
function-trace.cc refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
function-trace.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
get-drvs.cc fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
get-drvs.hh fix(3p/nix): convert all holders of EvalState into gc 2020-07-19 06:40:35 +00:00
json-to-value.cc refactor(3p/nix/libexpr): Back Nix lists with std::vector 2020-07-18 18:08:42 +00:00
json-to-value.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
lexer.l refactor(3p/nix/libexpr): Move some code out of lexer.l 2020-07-19 02:59:41 +00:00
names.cc fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
names.hh fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
nix-expr.pc.in feat(3p/nix): install pkgconfig files for libexpr, libmain and libstore 2020-06-21 20:42:28 +00:00
nixexpr.cc fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
nixexpr.hh fix(3p/nix): fix all UninitializedObject warnings 2020-07-24 22:18:23 +00:00
parser.cc fix(3p/nix): revert "apply all clang-tidy fixes" 2020-08-01 22:45:15 +00:00
parser.hh fix(3p/nix): Fix all remaining compiler warnings 2020-07-19 22:00:59 +00:00
parser.y fix(3p/nix): Fix all remaining compiler warnings 2020-07-19 22:00:59 +00:00
primops.cc fix(3p/nix): Use SkipEmpty in all calls to absl::StrSplit 2020-08-06 20:50:47 +00:00
primops.hh feat(3p/nix): remove builtins.importNative 2020-07-23 04:53:23 +00:00
symbol-table.cc refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
symbol-table.hh chore(3p): Bump nixpkgs channels 2020-08-06 00:15:33 +00:00
value-to-json.cc feat(3p/nix): remove External values feature 2020-08-01 18:54:50 +00:00
value-to-json.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
value-to-xml.cc feat(3p/nix): remove External values feature 2020-08-01 18:54:50 +00:00
value-to-xml.hh refactor(3p/nix): Anchor local includes at src/ 2020-05-27 21:56:34 +01:00
value.hh fix(3p/nix/libexpr): fix GC tracing in valueSize 2020-08-01 18:54:50 +00:00