Add --directory-service-addr arg to tvix-store CLI. Change-Id: Iea1e6f08f27f7157b21ccf397297c68358bd78a0 Reviewed-on: https://cl.tvl.fyi/c/depot/+/8743 Tested-by: BuildkiteCI Autosubmit: flokli <flokli@flokli.de> Reviewed-by: tazjin <tazjin@tvl.su>
147 lines
4.6 KiB
Rust
147 lines
4.6 KiB
Rust
use crate::{proto, B3Digest, Error};
|
|
use std::collections::HashMap;
|
|
use std::sync::{Arc, RwLock};
|
|
use tracing::{instrument, warn};
|
|
|
|
use super::utils::SimplePutter;
|
|
use super::{DirectoryPutter, DirectoryService, DirectoryTraverser};
|
|
|
|
#[derive(Clone, Default)]
|
|
pub struct MemoryDirectoryService {
|
|
db: Arc<RwLock<HashMap<B3Digest, proto::Directory>>>,
|
|
}
|
|
|
|
impl DirectoryService for MemoryDirectoryService {
|
|
/// Constructs a [MemoryDirectoryService] from the passed [url::Url]:
|
|
/// - scheme has to be `memory://`
|
|
/// - there may not be a host.
|
|
/// - there may not be a path.
|
|
fn from_url(url: &url::Url) -> Result<Self, Error> {
|
|
if url.scheme() != "memory" {
|
|
return Err(crate::Error::StorageError("invalid scheme".to_string()));
|
|
}
|
|
|
|
if url.has_host() || !url.path().is_empty() {
|
|
return Err(crate::Error::StorageError("invalid url".to_string()));
|
|
}
|
|
|
|
Ok(Self::default())
|
|
}
|
|
#[instrument(skip(self, digest), fields(directory.digest = %digest))]
|
|
fn get(&self, digest: &B3Digest) -> Result<Option<proto::Directory>, Error> {
|
|
let db = self.db.read()?;
|
|
|
|
match db.get(digest) {
|
|
// The directory was not found, return
|
|
None => Ok(None),
|
|
|
|
// The directory was found, try to parse the data as Directory message
|
|
Some(directory) => {
|
|
// Validate the retrieved Directory indeed has the
|
|
// digest we expect it to have, to detect corruptions.
|
|
let actual_digest = directory.digest();
|
|
if actual_digest != *digest {
|
|
return Err(Error::StorageError(format!(
|
|
"requested directory with digest {}, but got {}",
|
|
digest, actual_digest
|
|
)));
|
|
}
|
|
|
|
// Validate the Directory itself is valid.
|
|
if let Err(e) = directory.validate() {
|
|
warn!("directory failed validation: {}", e.to_string());
|
|
return Err(Error::StorageError(format!(
|
|
"directory {} failed validation: {}",
|
|
actual_digest, e,
|
|
)));
|
|
}
|
|
|
|
Ok(Some(directory.clone()))
|
|
}
|
|
}
|
|
}
|
|
|
|
#[instrument(skip(self, directory), fields(directory.digest = %directory.digest()))]
|
|
fn put(&self, directory: proto::Directory) -> Result<B3Digest, Error> {
|
|
let digest = directory.digest();
|
|
|
|
// validate the directory itself.
|
|
if let Err(e) = directory.validate() {
|
|
return Err(Error::InvalidRequest(format!(
|
|
"directory {} failed validation: {}",
|
|
digest, e,
|
|
)));
|
|
}
|
|
|
|
// store it
|
|
let mut db = self.db.write()?;
|
|
db.insert(digest.clone(), directory);
|
|
|
|
Ok(digest)
|
|
}
|
|
|
|
#[instrument(skip_all, fields(directory.digest = %root_directory_digest))]
|
|
fn get_recursive(
|
|
&self,
|
|
root_directory_digest: &B3Digest,
|
|
) -> Box<dyn Iterator<Item = Result<proto::Directory, Error>> + Send> {
|
|
Box::new(DirectoryTraverser::with(
|
|
self.clone(),
|
|
root_directory_digest,
|
|
))
|
|
}
|
|
|
|
#[instrument(skip_all)]
|
|
fn put_multiple_start(&self) -> Box<(dyn DirectoryPutter + 'static)>
|
|
where
|
|
Self: Clone,
|
|
{
|
|
Box::new(SimplePutter::new(self.clone()))
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::DirectoryService;
|
|
use super::MemoryDirectoryService;
|
|
|
|
/// This uses a wrong scheme.
|
|
#[test]
|
|
fn test_invalid_scheme() {
|
|
let url = url::Url::parse("http://foo.example/test").expect("must parse");
|
|
|
|
assert!(MemoryDirectoryService::from_url(&url).is_err());
|
|
}
|
|
|
|
/// This correctly sets the scheme, and doesn't set a path.
|
|
#[test]
|
|
fn test_valid_scheme() {
|
|
let url = url::Url::parse("memory://").expect("must parse");
|
|
|
|
assert!(MemoryDirectoryService::from_url(&url).is_ok());
|
|
}
|
|
|
|
/// This sets the host to `foo`
|
|
#[test]
|
|
fn test_invalid_host() {
|
|
let url = url::Url::parse("memory://foo").expect("must parse");
|
|
|
|
assert!(MemoryDirectoryService::from_url(&url).is_err());
|
|
}
|
|
|
|
/// This has the path "/", which is invalid.
|
|
#[test]
|
|
fn test_invalid_has_path() {
|
|
let url = url::Url::parse("memory:///").expect("must parse");
|
|
|
|
assert!(MemoryDirectoryService::from_url(&url).is_err());
|
|
}
|
|
|
|
/// This has the path "/foo", which is invalid.
|
|
#[test]
|
|
fn test_invalid_path2() {
|
|
let url = url::Url::parse("memory:///foo").expect("must parse");
|
|
|
|
assert!(MemoryDirectoryService::from_url(&url).is_err());
|
|
}
|
|
}
|