-- c99f979ad34f155fbeeea69b88bdc7458d89a21c by Derek Mauro <dmauro@google.com>: Remove a floating point division by zero test. This isn't testing behavior related to the library, and MSVC warns about it in opt mode. PiperOrigin-RevId: 285220804 -- 68b015491f0dbf1ab547994673281abd1f34cd4b by Gennadiy Rozental <rogeeff@google.com>: This CL introduces following changes to the class FlagImpl: * We eliminate the CommandLineFlagLocks struct. Instead callback guard and callback function are combined into a single CallbackData struct, while primary data lock is stored separately. * CallbackData member of class FlagImpl is initially set to be nullptr and is only allocated and initialized when a flag's callback is being set. For most flags we do not pay for the extra space and extra absl::Mutex now. * Primary data guard is stored in data_guard_ data member. This is a properly aligned character buffer of necessary size. During initialization of the flag we construct absl::Mutex in this space using placement new call. * We now avoid extra value copy after successful attempt to parse value out of string. Instead we swap flag's current value with tentative value we just produced. PiperOrigin-RevId: 285132636 -- ed45d118fb818969eb13094cf7827c885dfc562c by Tom Manshreck <shreck@google.com>: Change null-term* (and nul-term*) to NUL-term* in comments PiperOrigin-RevId: 285036610 -- 729619017944db895ce8d6d29c1995aa2e5628a5 by Derek Mauro <dmauro@google.com>: Use the Posix implementation of thread identity on MinGW. Some versions of MinGW suffer from thread_local bugs. PiperOrigin-RevId: 285022920 -- 39a25493503c76885bc3254c28f66a251c5b5bb0 by Greg Falcon <gfalcon@google.com>: Implementation detail change. Add further ABSL_NAMESPACE_BEGIN and _END annotation macros to files in Abseil. PiperOrigin-RevId: 285012012 GitOrigin-RevId: c99f979ad34f155fbeeea69b88bdc7458d89a21c Change-Id: I4c85d3704e45d11a9ac50d562f39640a6adbedc1
		
			
				
	
	
		
			113 lines
		
	
	
	
		
			4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			113 lines
		
	
	
	
		
			4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| // Copyright 2017 The Abseil Authors.
 | |
| //
 | |
| // Licensed under the Apache License, Version 2.0 (the "License");
 | |
| // you may not use this file except in compliance with the License.
 | |
| // You may obtain a copy of the License at
 | |
| //
 | |
| //      https://www.apache.org/licenses/LICENSE-2.0
 | |
| //
 | |
| #include "absl/strings/internal/str_format/arg.h"
 | |
| 
 | |
| #include <ostream>
 | |
| #include <string>
 | |
| #include "gtest/gtest.h"
 | |
| #include "absl/strings/str_format.h"
 | |
| 
 | |
| namespace absl {
 | |
| ABSL_NAMESPACE_BEGIN
 | |
| namespace str_format_internal {
 | |
| namespace {
 | |
| 
 | |
| class FormatArgImplTest : public ::testing::Test {
 | |
|  public:
 | |
|   enum Color { kRed, kGreen, kBlue };
 | |
| 
 | |
|   static const char *hi() { return "hi"; }
 | |
| };
 | |
| 
 | |
| TEST_F(FormatArgImplTest, ToInt) {
 | |
|   int out = 0;
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(FormatArgImpl(1), &out));
 | |
|   EXPECT_EQ(1, out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(FormatArgImpl(-1), &out));
 | |
|   EXPECT_EQ(-1, out);
 | |
|   EXPECT_TRUE(
 | |
|       FormatArgImplFriend::ToInt(FormatArgImpl(static_cast<char>(64)), &out));
 | |
|   EXPECT_EQ(64, out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(
 | |
|       FormatArgImpl(static_cast<unsigned long long>(123456)), &out));  // NOLINT
 | |
|   EXPECT_EQ(123456, out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(
 | |
|       FormatArgImpl(static_cast<unsigned long long>(  // NOLINT
 | |
|                         std::numeric_limits<int>::max()) +
 | |
|                     1),
 | |
|       &out));
 | |
|   EXPECT_EQ(std::numeric_limits<int>::max(), out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(
 | |
|       FormatArgImpl(static_cast<long long>(  // NOLINT
 | |
|                         std::numeric_limits<int>::min()) -
 | |
|                     10),
 | |
|       &out));
 | |
|   EXPECT_EQ(std::numeric_limits<int>::min(), out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(FormatArgImpl(false), &out));
 | |
|   EXPECT_EQ(0, out);
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(FormatArgImpl(true), &out));
 | |
|   EXPECT_EQ(1, out);
 | |
|   EXPECT_FALSE(FormatArgImplFriend::ToInt(FormatArgImpl(2.2), &out));
 | |
|   EXPECT_FALSE(FormatArgImplFriend::ToInt(FormatArgImpl(3.2f), &out));
 | |
|   EXPECT_FALSE(FormatArgImplFriend::ToInt(
 | |
|       FormatArgImpl(static_cast<int *>(nullptr)), &out));
 | |
|   EXPECT_FALSE(FormatArgImplFriend::ToInt(FormatArgImpl(hi()), &out));
 | |
|   EXPECT_FALSE(FormatArgImplFriend::ToInt(FormatArgImpl("hi"), &out));
 | |
|   EXPECT_TRUE(FormatArgImplFriend::ToInt(FormatArgImpl(kBlue), &out));
 | |
|   EXPECT_EQ(2, out);
 | |
| }
 | |
| 
 | |
| extern const char kMyArray[];
 | |
| 
 | |
| TEST_F(FormatArgImplTest, CharArraysDecayToCharPtr) {
 | |
|   const char* a = "";
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(a)),
 | |
|             FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl("")));
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(a)),
 | |
|             FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl("A")));
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(a)),
 | |
|             FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl("ABC")));
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(a)),
 | |
|             FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(kMyArray)));
 | |
| }
 | |
| 
 | |
| TEST_F(FormatArgImplTest, OtherPtrDecayToVoidPtr) {
 | |
|   auto expected = FormatArgImplFriend::GetVTablePtrForTest(
 | |
|       FormatArgImpl(static_cast<void *>(nullptr)));
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(
 | |
|                 FormatArgImpl(static_cast<int *>(nullptr))),
 | |
|             expected);
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(
 | |
|                 FormatArgImpl(static_cast<volatile int *>(nullptr))),
 | |
|             expected);
 | |
| 
 | |
|   auto p = static_cast<void (*)()>([] {});
 | |
|   EXPECT_EQ(FormatArgImplFriend::GetVTablePtrForTest(FormatArgImpl(p)),
 | |
|             expected);
 | |
| }
 | |
| 
 | |
| TEST_F(FormatArgImplTest, WorksWithCharArraysOfUnknownSize) {
 | |
|   std::string s;
 | |
|   FormatSinkImpl sink(&s);
 | |
|   ConversionSpec conv;
 | |
|   conv.set_conv(ConversionChar::FromChar('s'));
 | |
|   conv.set_flags(Flags());
 | |
|   conv.set_width(-1);
 | |
|   conv.set_precision(-1);
 | |
|   EXPECT_TRUE(
 | |
|       FormatArgImplFriend::Convert(FormatArgImpl(kMyArray), conv, &sink));
 | |
|   sink.Flush();
 | |
|   EXPECT_EQ("ABCDE", s);
 | |
| }
 | |
| const char kMyArray[] = "ABCDE";
 | |
| 
 | |
| }  // namespace
 | |
| }  // namespace str_format_internal
 | |
| ABSL_NAMESPACE_END
 | |
| }  // namespace absl
 |