-- c99f979ad34f155fbeeea69b88bdc7458d89a21c by Derek Mauro <dmauro@google.com>: Remove a floating point division by zero test. This isn't testing behavior related to the library, and MSVC warns about it in opt mode. PiperOrigin-RevId: 285220804 -- 68b015491f0dbf1ab547994673281abd1f34cd4b by Gennadiy Rozental <rogeeff@google.com>: This CL introduces following changes to the class FlagImpl: * We eliminate the CommandLineFlagLocks struct. Instead callback guard and callback function are combined into a single CallbackData struct, while primary data lock is stored separately. * CallbackData member of class FlagImpl is initially set to be nullptr and is only allocated and initialized when a flag's callback is being set. For most flags we do not pay for the extra space and extra absl::Mutex now. * Primary data guard is stored in data_guard_ data member. This is a properly aligned character buffer of necessary size. During initialization of the flag we construct absl::Mutex in this space using placement new call. * We now avoid extra value copy after successful attempt to parse value out of string. Instead we swap flag's current value with tentative value we just produced. PiperOrigin-RevId: 285132636 -- ed45d118fb818969eb13094cf7827c885dfc562c by Tom Manshreck <shreck@google.com>: Change null-term* (and nul-term*) to NUL-term* in comments PiperOrigin-RevId: 285036610 -- 729619017944db895ce8d6d29c1995aa2e5628a5 by Derek Mauro <dmauro@google.com>: Use the Posix implementation of thread identity on MinGW. Some versions of MinGW suffer from thread_local bugs. PiperOrigin-RevId: 285022920 -- 39a25493503c76885bc3254c28f66a251c5b5bb0 by Greg Falcon <gfalcon@google.com>: Implementation detail change. Add further ABSL_NAMESPACE_BEGIN and _END annotation macros to files in Abseil. PiperOrigin-RevId: 285012012 GitOrigin-RevId: c99f979ad34f155fbeeea69b88bdc7458d89a21c Change-Id: I4c85d3704e45d11a9ac50d562f39640a6adbedc1
		
			
				
	
	
		
			152 lines
		
	
	
	
		
			5.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			152 lines
		
	
	
	
		
			5.3 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| #include <string>
 | |
| 
 | |
| #include "gmock/gmock.h"
 | |
| #include "gtest/gtest.h"
 | |
| #include "absl/strings/str_format.h"
 | |
| 
 | |
| namespace absl {
 | |
| ABSL_NAMESPACE_BEGIN
 | |
| namespace str_format_internal {
 | |
| namespace {
 | |
| 
 | |
| std::string ConvToString(Conv conv) {
 | |
|   std::string out;
 | |
| #define CONV_SET_CASE(c) \
 | |
|   if (Contains(conv, Conv::c)) out += #c;
 | |
|   ABSL_CONVERSION_CHARS_EXPAND_(CONV_SET_CASE, )
 | |
| #undef CONV_SET_CASE
 | |
|   if (Contains(conv, Conv::star)) out += "*";
 | |
|   return out;
 | |
| }
 | |
| 
 | |
| TEST(StrFormatChecker, ArgumentToConv) {
 | |
|   Conv conv = ArgumentToConv<std::string>();
 | |
|   EXPECT_EQ(ConvToString(conv), "s");
 | |
| 
 | |
|   conv = ArgumentToConv<const char*>();
 | |
|   EXPECT_EQ(ConvToString(conv), "sp");
 | |
| 
 | |
|   conv = ArgumentToConv<double>();
 | |
|   EXPECT_EQ(ConvToString(conv), "fFeEgGaA");
 | |
| 
 | |
|   conv = ArgumentToConv<int>();
 | |
|   EXPECT_EQ(ConvToString(conv), "cdiouxXfFeEgGaA*");
 | |
| 
 | |
|   conv = ArgumentToConv<std::string*>();
 | |
|   EXPECT_EQ(ConvToString(conv), "p");
 | |
| }
 | |
| 
 | |
| #ifdef ABSL_INTERNAL_ENABLE_FORMAT_CHECKER
 | |
| 
 | |
| struct Case {
 | |
|   bool result;
 | |
|   const char* format;
 | |
| };
 | |
| 
 | |
| template <typename... Args>
 | |
| constexpr Case ValidFormat(const char* format) {
 | |
|   return {ValidFormatImpl<ArgumentToConv<Args>()...>(format), format};
 | |
| }
 | |
| 
 | |
| TEST(StrFormatChecker, ValidFormat) {
 | |
|   // We want to make sure these expressions are constexpr and they have the
 | |
|   // expected value.
 | |
|   // If they are not constexpr the attribute will just ignore them and not give
 | |
|   // a compile time error.
 | |
|   enum e {};
 | |
|   enum class e2 {};
 | |
|   constexpr Case trues[] = {
 | |
|       ValidFormat<>("abc"),  //
 | |
| 
 | |
|       ValidFormat<e>("%d"),                             //
 | |
|       ValidFormat<e2>("%d"),                            //
 | |
|       ValidFormat<int>("%% %d"),                        //
 | |
|       ValidFormat<int>("%ld"),                          //
 | |
|       ValidFormat<int>("%lld"),                         //
 | |
|       ValidFormat<std::string>("%s"),                   //
 | |
|       ValidFormat<std::string>("%10s"),                 //
 | |
|       ValidFormat<int>("%.10x"),                        //
 | |
|       ValidFormat<int, int>("%*.3x"),                   //
 | |
|       ValidFormat<int>("%1.d"),                         //
 | |
|       ValidFormat<int>("%.d"),                          //
 | |
|       ValidFormat<int, double>("%d %g"),                //
 | |
|       ValidFormat<int, std::string>("%*s"),             //
 | |
|       ValidFormat<int, double>("%.*f"),                 //
 | |
|       ValidFormat<void (*)(), volatile int*>("%p %p"),  //
 | |
|       ValidFormat<string_view, const char*, double, void*>(
 | |
|           "string_view=%s const char*=%s double=%f void*=%p)"),
 | |
| 
 | |
|       ValidFormat<int>("%% %1$d"),               //
 | |
|       ValidFormat<int>("%1$ld"),                 //
 | |
|       ValidFormat<int>("%1$lld"),                //
 | |
|       ValidFormat<std::string>("%1$s"),          //
 | |
|       ValidFormat<std::string>("%1$10s"),        //
 | |
|       ValidFormat<int>("%1$.10x"),               //
 | |
|       ValidFormat<int>("%1$*1$.*1$d"),           //
 | |
|       ValidFormat<int, int>("%1$*2$.3x"),        //
 | |
|       ValidFormat<int>("%1$1.d"),                //
 | |
|       ValidFormat<int>("%1$.d"),                 //
 | |
|       ValidFormat<double, int>("%2$d %1$g"),     //
 | |
|       ValidFormat<int, std::string>("%2$*1$s"),  //
 | |
|       ValidFormat<int, double>("%2$.*1$f"),      //
 | |
|       ValidFormat<void*, string_view, const char*, double>(
 | |
|           "string_view=%2$s const char*=%3$s double=%4$f void*=%1$p "
 | |
|           "repeat=%3$s)")};
 | |
| 
 | |
|   for (Case c : trues) {
 | |
|     EXPECT_TRUE(c.result) << c.format;
 | |
|   }
 | |
| 
 | |
|   constexpr Case falses[] = {
 | |
|       ValidFormat<int>(""),  //
 | |
| 
 | |
|       ValidFormat<e>("%s"),                  //
 | |
|       ValidFormat<e2>("%s"),                 //
 | |
|       ValidFormat<>("%s"),                   //
 | |
|       ValidFormat<>("%r"),                   //
 | |
|       ValidFormat<int>("%s"),                //
 | |
|       ValidFormat<int>("%.1.d"),             //
 | |
|       ValidFormat<int>("%*1d"),              //
 | |
|       ValidFormat<int>("%1-d"),              //
 | |
|       ValidFormat<std::string, int>("%*s"),  //
 | |
|       ValidFormat<int>("%*d"),               //
 | |
|       ValidFormat<std::string>("%p"),        //
 | |
|       ValidFormat<int (*)(int)>("%d"),       //
 | |
| 
 | |
|       ValidFormat<>("%3$d"),                     //
 | |
|       ValidFormat<>("%1$r"),                     //
 | |
|       ValidFormat<int>("%1$s"),                  //
 | |
|       ValidFormat<int>("%1$.1.d"),               //
 | |
|       ValidFormat<int>("%1$*2$1d"),              //
 | |
|       ValidFormat<int>("%1$1-d"),                //
 | |
|       ValidFormat<std::string, int>("%2$*1$s"),  //
 | |
|       ValidFormat<std::string>("%1$p"),
 | |
| 
 | |
|       ValidFormat<int, int>("%d %2$d"),  //
 | |
|   };
 | |
| 
 | |
|   for (Case c : falses) {
 | |
|     EXPECT_FALSE(c.result) << c.format;
 | |
|   }
 | |
| }
 | |
| 
 | |
| TEST(StrFormatChecker, LongFormat) {
 | |
| #define CHARS_X_40 "1234567890123456789012345678901234567890"
 | |
| #define CHARS_X_400                                                            \
 | |
|   CHARS_X_40 CHARS_X_40 CHARS_X_40 CHARS_X_40 CHARS_X_40 CHARS_X_40 CHARS_X_40 \
 | |
|       CHARS_X_40 CHARS_X_40 CHARS_X_40
 | |
| #define CHARS_X_4000                                                      \
 | |
|   CHARS_X_400 CHARS_X_400 CHARS_X_400 CHARS_X_400 CHARS_X_400 CHARS_X_400 \
 | |
|       CHARS_X_400 CHARS_X_400 CHARS_X_400 CHARS_X_400
 | |
|   constexpr char long_format[] =
 | |
|       CHARS_X_4000 "%d" CHARS_X_4000 "%s" CHARS_X_4000;
 | |
|   constexpr bool is_valid = ValidFormat<int, std::string>(long_format).result;
 | |
|   EXPECT_TRUE(is_valid);
 | |
| }
 | |
| 
 | |
| #endif  // ABSL_INTERNAL_ENABLE_FORMAT_CHECKER
 | |
| 
 | |
| }  // namespace
 | |
| }  // namespace str_format_internal
 | |
| ABSL_NAMESPACE_END
 | |
| }  // namespace absl
 |