It introduces a new accept_trace function for axum0.7 which can be used to accept a header trace from a received request. This function can be used for tonic 0.12 once that version is released, and the specific `accept_trace` function within `tvix_tracing::propagate::tonic` can then be removed. This also integrates http propagation into the nar_bridge crate. Change-Id: I46dcc797d494bb3977c2633753e7060d88d29129 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11925 Reviewed-by: Brian Olsen <me@griff.name> Tested-by: BuildkiteCI Reviewed-by: Simon Hauser <simon.hauser@helsinki-systems.de> Reviewed-by: flokli <flokli@flokli.de>
48 lines
1.9 KiB
Rust
48 lines
1.9 KiB
Rust
#[cfg(feature = "otlp")]
|
|
use opentelemetry::{global, propagation::Extractor};
|
|
#[cfg(feature = "otlp")]
|
|
use tracing_opentelemetry::OpenTelemetrySpanExt;
|
|
|
|
// TODO: accept_trace can be shared with tonic, as soon as tonic upstream has a release with
|
|
// support for axum07. Latest master already has support for axum07 but there is not release yet:
|
|
// https://github.com/hyperium/tonic/pull/1740
|
|
|
|
/// Trace context propagation: associate the current span with the otlp trace of the given request,
|
|
/// if any and valid. This only sets the parent trace if the otlp feature is also enabled.
|
|
pub fn accept_trace<B>(request: axum::http::Request<B>) -> axum::http::Request<B> {
|
|
// we only extract and set a parent trace if otlp feature is enabled, otherwise this feature is
|
|
// an noop and we return the request as is
|
|
#[cfg(feature = "otlp")]
|
|
{
|
|
// Current context, if no or invalid data is received.
|
|
let parent_context = global::get_text_map_propagator(|propagator| {
|
|
propagator.extract(&HeaderExtractor(request.headers()))
|
|
});
|
|
tracing::Span::current().set_parent(parent_context);
|
|
}
|
|
request
|
|
}
|
|
|
|
/// Helper for extracting headers from HTTP Requests. This is used for OpenTelemetry context
|
|
/// propagation over HTTP.
|
|
#[cfg(feature = "otlp")]
|
|
struct HeaderExtractor<'a>(&'a axum::http::HeaderMap);
|
|
|
|
#[cfg(feature = "otlp")]
|
|
impl<'a> Extractor for HeaderExtractor<'a> {
|
|
/// Get a value for a key from the HeaderMap. If the value is not valid ASCII, returns None.
|
|
fn get(&self, key: &str) -> Option<&str> {
|
|
self.0.get(key).and_then(|v| {
|
|
let s = v.to_str();
|
|
if let Err(ref error) = s {
|
|
tracing::warn!(%error, ?v, "cannot convert header value to ASCII")
|
|
};
|
|
s.ok()
|
|
})
|
|
}
|
|
|
|
/// Collect all the keys from the HeaderMap.
|
|
fn keys(&self) -> Vec<&str> {
|
|
self.0.keys().map(|k| k.as_str()).collect()
|
|
}
|
|
}
|